Giter Site home page Giter Site logo

Comments (8)

nicoddemus avatar nicoddemus commented on June 16, 2024

Hi @wimglenn,

Mostly because we rely on projects having a tox.ini file, which is only present in sdists.

About mentioning that somewhere on the README it makes sense, would you like to submit a PR? 😁

from plugincompat.

wimglenn avatar wimglenn commented on June 16, 2024

Oh OK - didn't realize this project was actually executing each plugin test suite, but it makes sense.

The OVERVIEW.md says:

If a plugin doesn't have a tox.ini file, we generate a simple tox.ini which just ensures that the plugin was installed successfully by running pytest --help.

But this is possible with bdist also, isn't it?

You might find more maintainers these days only using sdist if there needs to be extensions compiled..

from plugincompat.

The-Compiler avatar The-Compiler commented on June 16, 2024

I'm not aware of any pytest plugins which need extensions - are there any?

from plugincompat.

wimglenn avatar wimglenn commented on June 16, 2024

I'm not aware either, and it's beside the point. The scripts look for projects doing CI with a tox.ini and making sdist avail, but it means that there can be some false negatives listed on the website.

from plugincompat.

nicoddemus avatar nicoddemus commented on June 16, 2024

Oh yeah false negatives have always been a possibility, because some plugins might have complex dependencies (libraries, services, etc). pytest-qt is an example of that: besides needing PyQt5 or PySide, it also requires an xvfb server running, so plugincompat can't really test it.

from plugincompat.

wimglenn avatar wimglenn commented on June 16, 2024

@nicoddemus What do you think of giving a tick to a .whl with the correct filename tags ({distribution}-{version}(-{build tag})?-{python tag}-{abi tag}-{platform tag}.whl) which installs and displays in the pytest --help correctly? We can of course prefer sdist if available, and fall back to checking bdists...

from plugincompat.

nicoddemus avatar nicoddemus commented on June 16, 2024

What do you think of giving a tick to a .whl with the correct filename tags ({distribution}-{version}(-{build tag})?-{python tag}-{abi tag}-{platform tag}.whl) which installs and displays in the pytest --help correctly?

Sounds like a good compromise. Would you like to open a PR? Should be simple enough to implement.

I've been thinking how useful those ticks are in reality TBH, because they give too much false negatives... it might be better to just list the plugins and their descriptions, and which Python version they declare to support. I don't know.

from plugincompat.

wimglenn avatar wimglenn commented on June 16, 2024

I began to work on it but there were some little things I was fixing up until it seemed there was so many of these that they should go in separate PR (see #26) so that it doesn't obscure the actual change too much.

But now it seems that travis-ci, as used to execute run.py and post results, is interfering with the PR builder. Could you untangle that so the PR builder is just executing the suite in test_web.py instead?

from plugincompat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.