Giter Site home page Giter Site logo

Comments (6)

schlamar avatar schlamar commented on June 14, 2024

Already implemented and released: #4

from pytest-cov.

schlamar avatar schlamar commented on June 14, 2024

If you are already using using the new version, please give me more details, so we can work this out :) A failing test case would be the best.

from pytest-cov.

carljm avatar carljm commented on June 14, 2024

Well, that's embarrassing. The new version does fix this. I didn't try upgrading because I looked at the latest code on GitHub, and although I saw the pytest_load_initial_conftests hook, it still looked to me like the actual start of coverage measurement didn't happen until the pytest_sessionstart hook in CovPlugin. But I guess pytest_sessionstart must fire earlier than I realized, at least in the non-distributed case?

In any case, thanks for having already fixed this, and sorry for the noise :-) Feel free to close.

from pytest-cov.

schlamar avatar schlamar commented on June 14, 2024

Only slave coverage is started in pytest_sessionstart. Default coverage and coverage from the master in distributed case are actually started from pytest_load_initial_conftests in CovPlugin.__init__

from pytest-cov.

schlamar avatar schlamar commented on June 14, 2024

BTW, I know the code is badly structured, that's for legacy reasons. I'm the maintainer for just a few months now. I'm planning a bigger rewrite but that's still in my head right now...

from pytest-cov.

carljm avatar carljm commented on June 14, 2024

I see it now. Still don't know I missed the calls to start in CovPlugin.__init__.

Thanks for picking up maintenance of pytest-cov!

from pytest-cov.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.