Giter Site home page Giter Site logo

Comments (6)

bialix avatar bialix commented on August 19, 2024

IIRC this record should be selected based on starting address type. But I see what you mean, and this is valid request.
For pull request we need a corresponding unit test, please. You can ask for tips and some help with writing a patch.

from intelhex.

bialix avatar bialix commented on August 19, 2024

BTW, do you have starting address record in your file?

from intelhex.

fernandez85 avatar fernandez85 commented on August 19, 2024

No, I don't use it in my project.
I have only "bare" data. So there is only Data and Extend Address records (and End of File record of course).
In matter of fact I have to delete Starting Address info in some cases. I need to integrate some hex files (which have that record included) into one. But this is not a problem.
BTW, maybe I'm missing something, but I don't see any connection between Starting Address and Extend Address records. Only that both can be "Segment" or "Linear", but this is just a type/mode of addressing.

from intelhex.

bialix avatar bialix commented on August 19, 2024

Only that both can be "Segment" or "Linear", but this is just a type/mode of addressing.

Well, that is. But you can probably expect to get only one type of addressing to be using in one document. I don't think mix of two is a good idea. It's counterintuituive for me.
Anyway, start address type could be used only to guess the mode, but in your case it's better to be able to override the mode aand set the desired one.

from intelhex.

bialix avatar bialix commented on August 19, 2024

I need to integrate some hex files (which have that record included) into one.

That's why I've added merge feature. I hope it works for you.

from intelhex.

fernandez85 avatar fernandez85 commented on August 19, 2024

Well, that is. But you can probably expect to get only one type of addressing to be using in one document. I don't think mix of two is a good idea. It's counterintuituive for me.

For me it is always good idea to have one type of addressing for simple consistency reasons. But believe me, there are tools that do the really crazy stuff on output. Then it is expected that Your software will support that. And on the end You have to struggle with this ;)

Anyway, start address type could be used only to guess the mode, but in your case it's better to be able to override the mode aand set the desired one.

I have a solution in mind to cope all the scenarios. I will present this as soon the change will be ready.

That's why I've added merge feature. I hope it works for you.

I know I can use it, but I just use 'fromFile'. I don't have manipulate the data (besides deleting Starting Address info data, but this I do right after loading the data). Just open and load, so for me this is simpler than calling the constructor (which opens and loads data inside) and then merge. Unless 'merge' has some extra features that would change my mind ;)

from intelhex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.