Giter Site home page Giter Site logo

Unknown test comment about pillow HOT 6 CLOSED

Yay295 avatar Yay295 commented on June 15, 2024
Unknown test comment

from pillow.

Comments (6)

hugovk avatar hugovk commented on June 15, 2024

There's an archive of the old Mercurial repo at https://bitbucket-archive.softwareheritage.org/projects/ef/effbot/pil-2009-raclette.html

I have a copy at https://github.com/hugovk/pil-2009-raclette

The commit is "Handle long integers in putpixel/putdata." by Fredrik aka effbot on Apr 25, 2010:

hugovk/pil-2009-raclette@52970c6

Maybe you can find something in the repo metadata at softwareheritage.

from pillow.

Yay295 avatar Yay295 commented on June 15, 2024

Oh, interesting. It looks like the L suffixes were probably removed when going from Python 2 to 3, which is why there are some duplicate lines in that test now.

from pillow.

nulano avatar nulano commented on June 15, 2024

Checking the metadata archive from https://bitbucket-archive.softwareheritage.org/projects/ef/effbot/pil-2009-raclette.html, I get no hits with grep for "systemerror", "putpixel", nor "putdata".

I've also tried checking the Image-SIG mailing list archive, but I can't see anything relevant.

from pillow.

nulano avatar nulano commented on June 15, 2024

The commit is "Handle long integers in putpixel/putdata." by Fredrik aka effbot on Apr 25, 2010:
hugovk/pil-2009-raclette@52970c6

The Pillow version of that commit is c8ce29c from #35:

FIX: Handle long values in _imaging getink

This gets the putdata test case to run correctly under 2.6/2.7. It fixes an
issue where the value 0xFFFFFFFF (which is long in old Python) isn't
recognized and putdata tries to parse it as a tuple.

The original fix comes from Christoph Gohlke. It was adapted to work in
both 2.* and 3.*.

from pillow.

Yay295 avatar Yay295 commented on June 15, 2024

That seems like the answer to me. I don't know what the exact error report was, but it looks like it was something to do with big numbers and Python 2/3 compatibility.

from pillow.

radarhere avatar radarhere commented on June 15, 2024

#8017 now suggests removing this comment.

from pillow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.