Giter Site home page Giter Site logo

Comments (12)

omab avatar omab commented on June 7, 2024

Fixed by 7b8d445

from social-app-django.

nijel avatar nijel commented on June 7, 2024

Are you sure the fix is complete? The clean_authenticate_args method does not seem to be called anywhere...

Okay sorry, I didn't notice relevant commits in social_core, it now indeed works fine.

from social-app-django.

nijel avatar nijel commented on June 7, 2024

Anyway I've figured out why it doesn't work as expected for me with your fix - the request is no longer available to the pipeline, I've created #27 which does fix it.

from social-app-django.

omab avatar omab commented on June 7, 2024

@nijel the fix was correct, but indeed if Django used to pass the request as a keyword argument, it was now missing, the request was still available by doing strategy.request.

from social-app-django.

nijel avatar nijel commented on June 7, 2024

What was more tricky is that the parameter was not missing, but it was empty dict instead, what make it a bit more tricky to discover. Using strategy.request seems to be better approach in this case, thanks for suggestion.

from social-app-django.

nijel avatar nijel commented on June 7, 2024

Any plans to release social-app-django with this fix?

from social-app-django.

omab avatar omab commented on June 7, 2024

@nijel, social-core 1.2.0 and social-app-django 1.1.0 released

from social-app-django.

nijel avatar nijel commented on June 7, 2024

Thanks!

from social-app-django.

naveen319 avatar naveen319 commented on June 7, 2024

Can some some help me with this issue?
i am getting this same error for both google and twitter authentication.

TypeError at /social-auth/complete/facebook/
unsupported operand type(s) for +: 'NoneType' and 'int'
Request Method: GET
Request URL: http://mysite.com:8000/social-auth/complete/facebook/?redirect_state=TAQXEiEM8ybAubXtpIaNWj2OVNkGvOIH&code=AQDcFXPfxoGsMQwOVeZqHH3tCIEYKRw1ZMIwSdpY-NtONZJ6bklg_olWmQU1F2LlPjlF45VZBY2V1BtHdHAs0RKcCAtpzZ3hxmjTv-ckcv1Yg5CgxRqGDK6DK9q5I0uB9RBFUUhWZOU0RqXB7iYf-PhsK5H_-WzFcbYCmZ8v41EWKmcpQkx82Ro90kmAWwIkGT8c9Ky8DLiFVTwsFfZk4k-nomd4L_L9j3b_0dXvnGYzEIouqWZFqrGEdGaXL3BC2bmRHaTBLwsDp1FWo6WxAGW9nlQWDeXXdS_uBEwTj9f-4vjKK6TFAwJlsPLLBm6EPyQ8uiNGni1tD50cvYIL9FoWSzblKfUYOehrR-0ZmYGXuw&state=TAQXEiEM8ybAubXtpIaNWj2OVNkGvOIH
Django Version: 1.11.2
Exception Type: TypeError
Exception Value:
unsupported operand type(s) for +: 'NoneType' and 'int'
Exception Location: C:\Python34\lib\site-packages\social\backends\base.py in run_pipeline, line 110
Python Executable: C:\Python34\python.exe
Python Version: 3.4.3
Python Path:
['C:\Users\bvsr\PycharmProjects\bookmarks',
'C:\Users\bvsr\PycharmProjects\bookmarks',
'C:\WINDOWS\SYSTEM32\python34.zip',
'C:\Python34\DLLs',
'C:\Python34\lib',
'C:\Python34',
'C:\Python34\lib\site-packages']
Server time: Tue, 27 Jun 2017 23:33:49 +0000

image

from social-app-django.

omab avatar omab commented on June 7, 2024

@naveen241192 don't hijack issues please.

from social-app-django.

luok4n avatar luok4n commented on June 7, 2024

@naveen241192 @omab
i have the same problem.
can you resolved it?
thanks

from social-app-django.

omab avatar omab commented on June 7, 2024

Open a new issue, @naveen241192 comment wasn't related to the original ticket, so it was never answered.

from social-app-django.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.