Giter Site home page Giter Site logo

Comments (6)

filmor avatar filmor commented on May 10, 2024

Could you give more details on how this could be implemented?

from pythonnet.

tonyroberts avatar tonyroberts commented on May 10, 2024

I've not really looked in too much detail I'm afraid, but I was thinking that if tp_bases on the type structure was set to a tuple of base classes, including the interfaces, then that would make isinstance work. From memory, I think currently tp_base is set and tp_bases is set to NULL.

from pythonnet.

filmor avatar filmor commented on May 10, 2024

Looking a bit deeper into this, I think this should be implemented in the metaclass instead, by means of __instancecheck__ (works only from 2.6 onwards, but that should be enough). If you add the interfaces to tp_bases it will fail on method resolution as "mro() returned base class with unsuitable layout". In the end, the interfaces aren't really base classes anyway.

from pythonnet.

den-run-ai avatar den-run-ai commented on May 10, 2024

@filmor is this now implemented in your pull request here?

#167

from pythonnet.

filmor avatar filmor commented on May 10, 2024

Yep, it is.

from pythonnet.

tonyroberts avatar tonyroberts commented on May 10, 2024

Fixed in #167.

from pythonnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.