Comments (3)
Let's be more specific about what I think should change in this detail2.html template:
- its name
- fontawesome should go away, the remaining part of the site uses Open Iconic, fontawesome was interesting becaused it shipped with Bootstrap 3, Bootstrap 4 no longer does.
<script type='text/javascript'>var CONTEXT_ROOT = '/ea-action';</script>
<script type='text/javascript' src='/static/eaCommon.js'></script>
<script type='text/javascript' src='/static/eaAJAX.js'></script>
<script type='text/javascript' src='/static/eacampaign.js'></script>
- Those should go away as well. They are copy paste from an old Greenpeace petition, I don't even know which kind of copyright or license applies on those files and I guess we use very few of the features brought by those. Let's just integrate the minimum we need and remove the files altogether.
- think about dropping typeahead, is it really needed?
"Important" features to keep IMO:
- Color of "Sign button", or at least have a nice style, not the default HTML5 button style.
- Color of signature number loading bar
- The fact that the signature number loading bar "loads" at page startup (animation)
- The fact that the right panel follows the scroll and sticks to the top when it reaches it.
- Keep it reactive, like https://petition.antipub.org/petition/4/ so that when it is viewed on smartphone or small screen the right panel stacks up with the petition and the "sign" button follows the scrolling/reading.
- Error feedbacks on the signature submission form
from pytition.
its name
Yes !
fontawesome should go away, the remaining part of the site uses Open Iconic, fontawesome was interesting becaused it shipped with Bootstrap 3, Bootstrap 4 no longer does.
Ok, I did not found exactly the same icons but it should work.
think about dropping typeahead, is it really needed?
I agree, it is not really needed.
The fact that the right panel follows the scroll and sticks to the top when it reaches it.
It is.
Keep it reactive, like https://petition.antipub.org/petition/4/ so that when it is viewed on smartphone or small screen the right panel stacks up with the petition and the "sign" button follows the scrolling/reading.
I can use order
flexbox property
And ok for the others features, I have to test the petition signature for some of them.
from pytition.
I think we can close this.
Thanks again! :)
from pytition.
Related Issues (20)
- Provide a LDAP backend option for login
- error installation HOT 4
- Add social network sharing buttons that do not track visitors
- Error when running all tests through Docker HOT 1
- Show petition creation date on petition page HOT 13
- create petition tags
- Update Django to 3.2 LTS HOT 1
- Add a comment area
- Create a "petition's news" section
- Add Victory thumnail
- Separate the website in several tabs
- Add a share button in a petition's page HOT 2
- Issues with phone number validation : for instance 07 does not work for France HOT 2
- show a warning on petition page if unpublished
- TinyMCE not changing language to French HOT 3
- Allow to personnalize the social network sharing default texts per-petition
- Allow to chose which social network sharing button to show or not HOT 6
- Translation FR : Petition title field label HOT 1
- Translation FR : Petition edit form labels
- [Admin] Enable user creation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pytition.