[New Rule Request] Torchfix should issue a warning when a torch.nn.Module stores its layers in a python list instead of a torch.nn.ModuleList

[pytorch-labs]

[New Rule Request] Torchfix should issue a warning when a torch.nn.Module stores its layers in a python list instead of a torch.nn.ModuleList

[ssgosh]

Yikes! Perhaps it can be done on a best-effort basis for some commonly-used class types, such as Linear, Conv2d and other subclasses of torch.nn.Module as found here: https://pytorch.org/docs/stable/nn.html ? Maybe it can be done only for list comprehensions? I would imagine that it's a common idiom that many people use.

[kit1980]

Sounds like a good idea.
I personally helped people who had this issue.

[kit1980]

This seems a bit tricky to implement.
Currently TorchFix doesn't know the types of the objects, so it's hard to find lists of torch.nn.Module objects.

pyre and TypeInferenceProvider https://libcst.readthedocs.io/en/latest/metadata.html#libcst.metadata.TypeInferenceProvider can probably help here, but it's a separate feature to implement.