Giter Site home page Giter Site logo

Comments (4)

ejguan avatar ejguan commented on May 18, 2024 1

We added a deprecation warning in PyTorch
https://github.com/pytorch/pytorch/blob/e3af4be96338d0645310e7cab47ce78509a6603e/torch/utils/data/datapipes/iter/tararchivereader.py#L37
We will remove them in the next release after 1.10. Before that, if any user imports DataPipe from torchdata, they should use the one in torchdata rather than the one in pytorch core.

For the list of duplicated DataPipes, we should not expose them from PyTorch core to torchdata but directly use the implementation from torchdata.

from data.

pmeier avatar pmeier commented on May 18, 2024 1

I'll send a PR.

from data.

ejguan avatar ejguan commented on May 18, 2024

That's a good idea to have a single source of Truth. And, we need to carefully take care of duplicated DataPipes like TarArchiveReader without overriding them from data repo.

Feel free to send a PR.

from data.

pmeier avatar pmeier commented on May 18, 2024

That's a good idea to have a single source of Truth. And, we need to carefully take care of duplicated DataPipes like TarArchiveReader without overriding them from data repo.

The second part makes it sound that there is no single source of truth if torchdata.datapipes diverges from torch.utils.data.datapipes. Looking at TarArchiveReader, I found this

# TODO(VitalyFedyunin): This file copy-pasted from the pytorch repo
# nuke source class when repo is open-sourced

So what is the plan here? Remove everything from torch.utils.data.datapipes that is also in torchdata.datapipes and import and expose the rest?

from data.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.