Is this available on windows?

[pytorch]

Is this available on windows?

[ykim362]

@dskhudia @peterjc123 @snaik2016 Actually, I've made FBGEMM fully functional on windows. https://github.com/marian-nmt/FBGEMM
It's based on 518d8a1 .
This fork of FBGEMM is used in marian-nmt.

I could do rebase on the latest branch, if needed.
I am aware of there are some new code including AVX512 based fp16. And, I have a little more code clean up.

[dskhudia]

Hi @snaik2016,

We haven't tried building it on windows. We expect some issues as we generate code at runtime and the calling convention is different with windows compiler + platform. There may be some compiler incompatibility issues as well. However, we don't expect any major changes. Currently the support on windows platform is not planned to be added in near future but we welcome external contributions.

Thanks
Daya

[peterjc123]

I tried with #238. Due to the fact that I don't have too much knowledge about assembly code, I cannot proceed any further. Could you please take a look there?

[dskhudia]

@peterjc123 Thanks for your contributions. Let me look at your PR. I have been making some progress on this with d06ea70 c960d51 fc3dfe3 and others recently.

[shz0116]

Can this library be built on windows?

@snaik2016 we are trying to port the code to Windows platform. One question is whether you need both Static and Shared FBGEMM libraries, or just static ? Do you know how important shared library is on Windows platforms compared with static ?
Icc @peterjc123 and @ykim362 @dskhudia @jspark1105

[ykim362]

@shz0116 In my use case in marian-nmt, I directly include those FBGEMM file into my marian VS project. And, the mother VS project generates a shared library (dll). So, I am using a shared library (I use all the files in FBGEMM). I use ' FBGEMM_EXPORTS' definition in the project.

[shz0116]

@ykim362 so you have not seen the problem in https://github.com/pytorch/FBGEMM/issues/266 ?

[ykim362]

@shz0116 I don't have a problem in my forked branch. ( https://github.com/marian-nmt/FBGEMM ). I might need to merge the latest FBGEMM branch into marian-nmt, soon. So, I will let you know how it goes.

[ykim362]

@shz0116 I can see one difference between the old version and the latest version. 'FBGEMM_EXPORTS' is forcely defined in some cc files in the latest version.
e.g.

FBGEMM/src/PackAWithQuantRowOffset.cc

Line 7 in 27cb280

#define FBGEMM_EXPORTS

Could this cause potential mismatches between dllimport and dllexport?
In the PackAWithQuantRowOffset.cc file, it's defined with dllexport because of the definition. On the other hand, in other files (e.g. PackedFloatInOutBenchmark.cc), Fbgemm.h is included without FBGEMM_EXPORTS resulting dllimport.

[peterjc123]

Can this library be built on windows?

@snaik2016 we are trying to port the code to Windows platform. One question is whether you need both Static and Shared FBGEMM libraries, or just static ? Do you know how important shared library is on Windows platforms compared with static ?
Icc @peterjc123 and @ykim362 @dskhudia @jspark1105

I guess the static build is okay if the size is not too big. Otherwise, it will fail in the linking stage because PyTorch is already large enough.

[peterjc123]

The shared build should be working in #268.

[dskhudia]

FBGEMM works on windows now. Closing this issue.