Giter Site home page Giter Site logo

Comments (5)

malfet avatar malfet commented on June 2, 2024

Thank you for reporting. We will accept a PR that either amends the doc or changes argument name on the Torch side to match the documentation

from pytorch.

albanD avatar albanD commented on June 2, 2024

Changing argument names in the code would be bc-breaking. So we should update the doc here.
The problem IIRC for these is that we do funky renaming when exposing these so it's not super easy to do the rename, but we should find a way to update that doc yes!

from pytorch.

malfet avatar malfet commented on June 2, 2024

I agree that it's a potentially BC-breaking change, but I'm not sure if anyone is invoking dot with tensor= (cursory look thru https://github.com/search?type=code&q=tensor%3D+torch.dot kind of confirms the theory)

from pytorch.

albanD avatar albanD commented on June 2, 2024

I'm not saying it is used. More that one option is BC breaking and one is not. So I would lean towards the non-BC breaking one by default.

from pytorch.

hippocookie avatar hippocookie commented on June 2, 2024

May I help to fix this by adding explanation in doc

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.