Giter Site home page Giter Site logo

Comments (1)

jbschlosser avatar jbschlosser commented on June 12, 2024 1

I haven't gotten around to investigating this yet. Maybe #126198 is related (just based on unbacked symint <-> NT issues).

I ran into a similar error, which prompted the fix in the linked PR.

FWIW I was able to get your repro working without graph breaks using a combination of:

  • #122836
    • Dynamic shapes support for min / max sequence length + proper propagation of the two within torch.compile
  • #126198
    • Fix for unbacked SymInts
  • #124803
    • Fix to is_concrete_int() to return true for nested ints
  • #126563
    • Avoid problem of getting multiple nested ints for the same dimension
    • I tried #124624 here, but that didn't work for me. I think there's another unbacked SymInt issue, but I also don't really understand why we need unbacked SymInts as used in that PR. So I took a simpler approach and it seems to work. I guess based on @soulitzer's comments that it'll break when we have grads?

from pytorch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.