Screenshot dimensions inconsistent between plotters

[pyvista]

Screenshot dimensions inconsistent between plotters

[akaszynski]

Saw this in the source:

# NOTE: setting BasePlotter is unnecessary and Segfaults CI

My guess is that we're not setting the window size using a signal. If we use a signal and set the window size that way, we should have the correct window size. My guess is that the window size of the widget is smaller because it's inside of the main window which includes toolbars, menus, and the border of the window itself.

[GuillaumeFavelier]

I think this can be moved to pyvistaqt :)

[GuillaumeFavelier]

I inspected the code and this is where window_size is set:

Plotter:

https://github.com/pyvista/pyvista/blob/master/pyvista/plotting/plotting.py#L600-L603

BackgroundPlotter:

https://github.com/pyvista/pyvista/blob/master/pyvista/plotting/qt_plotting.py#L856-L862

[banesullivan]

My guess is that the window size of the widget is smaller because it's inside of the main window which includes toolbars, menus, and the border of the window itself.

I think Alex is right. A while back, I ran into some really weird behavior when tracking the viewport coordinates of the mouse (or maybe it was widget placement) over the BackgroundPlotter... I can't remember if I posted about it or not... I'll try to dig it up

[benjamindkilleen]

Has this issue been fixed in BackgroundPlotter? I had the same issue when trying to use off_screen=True. No matter what, the screenshot window_size was (300, 300). This is an edge case, since I could just use pv.Plotter() in the off_screen case, but perhaps BackgroundPlotter should not support off_screen=True, directing the user to use pv.Plotter().

[GuillaumeFavelier]

AFAIK, it's still not resolved. In MNE-Python, where we use BackgroundPlotter currently, we had to use a "tweak" to ensure the proper size of the 3d viewer.