Check if it works on Windows and macOS, fix if necessary

[pzmarzly]

Check if it works on Windows and macOS, fix if necessary

[nicbn]

Won't compile on Windows
https://pastebin.com/CpRmNHNf

[pzmarzly]

Thanks.

I initially thought get_if_addrs was going to be a problem (perhaps different structs representing the network interface, depending on the OS - but I just looked at the source code and it's not the case).

It makes a lot of sense for the Ctrl+C listener to be a problem. I think it would be enough to just rewrite this part:

portforwarder-rs/src/bin/pf.rs

Lines 90 to 106 in 6649b28

	use chan_signal::Signal;
	let signal = chan_signal::notify(&[Signal::INT, Signal::TERM]);
	for port in parsed_ports {
	match forwarder.forward_port(port.1, port.2, port.0, "PortForwardRs") {
	Ok(_) => println!("{} {}:{} -> {}:{}", port.0, forwarder.gateway.addr.ip(), port.2, forwarder.network_interface, port.1),
	Err(err) => eprintln!("Error! Could map {} {}:{} -> {}:{} - {}", port.0, forwarder.gateway.addr.ip(), port.2, forwarder.network_interface, port.1, err),
	}
	}
	println!("Going to sleep... Press Ctrl-C to close program.");
	chan_select! {
	signal.recv() -> signal => {
	println!("Received {:?}, shutting down...", signal)
	}
	}

to use the cross-platform ctrlc crate.

I can work on it next week, unless you want to fix it yourself and open a PR.

[eutampieri]

I think I could have a look if you didn’t have time

[pzmarzly]

Sure, go ahead.

I consider the project done for me (it does all I wanted), so I'm not keen on spending time on it, but I would gladly merge working code, especially if it means making the project useful for more people.

[eutampieri]

Ok, on macOS compiles. I will check on Windows as soon as I have time