Giter Site home page Giter Site logo

Comments (5)

q-p avatar q-p commented on May 27, 2024

The up-mix matrix is described in the commit message here 42b2f23

As you can see the original 5.1 channels are passed through but the up-mix is performed and added additionally. SoundPusher doesn't look at the audio data at all, and preferably I'd keep it that way.

The main problem I see is that detecting >2 channels is easy (was there any signal on the non-L/R channels in the last N frames?), but the converse is not, because you could have a 5.1 signal that purposely has silence everywhere but the L/R channels.

from soundpusher.

GrandfatherTrout avatar GrandfatherTrout commented on May 27, 2024

I see, so the 5.1 is actually sounding, but an upmix from the stereo is also added to the back L+R channels...
And so what you are saying, for SoundPusher there is no difference in a 5.1 stream with silence in the back L+R than a stereo stream? So it would have to find another way to see whether the file that is streaming through is 2ch or 6ch source.
To me it would be really cool if I could randomly stream 6ch and 2ch files with only the stereo files being upmixed, but I understand if that is difficult to do.

from soundpusher.

q-p avatar q-p commented on May 27, 2024

And so what you are saying, for SoundPusher there is no difference in a 5.1 stream with silence in the back L+R than a stereo stream?

Yes, that's the essence. The audio device (in this case LoopbackAudio) is always 5.1 channels, but which channels the application "feeds" depends on the application, and I don't know of a good way to transport "intent".

As I said, technically, it's not hard to insert a silence detection heuristic and toggle upmixing based on that, but it will always be wrong occasionally.

What are you using to play your tracks? Maybe it's possible to add the upmix on the application side, where the knowledge of the source format is still there?

from soundpusher.

GrandfatherTrout avatar GrandfatherTrout commented on May 27, 2024

I use Swinsian. It is the most flexible music player I know and I tried everything else I could get my hands on - it works like iTunes used to work before Apple ruined it and can handle very large music libraries. It also has the ability to play lossless and multi-channel formats and switch between them on the fly (I am not affiliated - I am using it for several years now and it has stood the test of time)
I wonder how often a silence detection would actually get it wrong in a real-world test, you would probably have to introduce a delay so SoundPusher can examine a certain portion ahead of time?

from soundpusher.

q-p avatar q-p commented on May 27, 2024

No, there wouldn't be any additional delay, you'd instead switch in one direction (when turning upmix back on) a fixed amount of time too late (for however long you decide you need to not hear anything on all surround channels for you to assume it really is only 2 channel content — but this really can't be too short because otherwise you'd get weird flips of upmix on/off just because some channels were silent for too long in a real 5.1 context).

from soundpusher.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.