Smart Contract cli.transact_and_wait returning nil, instead for error message

[kyleboureston]

Smart Contract cli.transact_and_wait returning nil, instead for error message

[q9f]

Yes, this means that your transaction didn't succeed. I just reviewed the logic and we throw an error, if something goes wrong and return a hash if it succeeds. However, currently, there is no logic to inform you if something happens to the transaction execution in the virtual machine.

I'll think about a better handling here.

[zackisaacs]

I've noticed the problem (transact_and_wait returns nil) when connecting to infura, even when the transaction succeeds. I believe the problem is not wait_for_tx(transact(contract, function, *args, **kwargs)) fails here:

eth.rb/lib/eth/client.rb

Line 318 in 041aa92

hash = wait_for_tx(transact(contract, function, *args, **kwargs))

but that tx_succeeded? hash returns false shortly thereafter here:

eth.rb/lib/eth/client.rb

Line 319 in 041aa92

return hash if tx_succeeded? hash

My guess is that the transaction receipt doesn't propagate to the network readers used by infura quickly enough when calling eth_get_transaction_receipt(hash) here:

eth.rb/lib/eth/client.rb

Line 366 in 041aa92

tx_receipt = eth_get_transaction_receipt(hash)

Writing and then not being able to read right after is a pretty common race condition. Could solve by updating tx_succeeded?(hash) to retry if tx_receipt["result"].nil? == true here:

eth.rb/lib/eth/client.rb

Line 367 in 041aa92

!tx_receipt.nil? && !tx_receipt["result"].nil? && tx_receipt["result"]["status"] == "0x1"

If this is something you'd like to see, I'd be happy to submit a PR.

[q9f]

I'll gladly review such a PR, thanks!