Giter Site home page Giter Site logo

Comments (5)

qarmin avatar qarmin commented on September 24, 2024 1

Creating 4 hashes of 1 file, may slows down program even more than 4 times.

Calculating image hashes and saving/loading cache from file probably will be ~3/4 times slower, but hash comparing will be slower even more, because entire(quite now optimized) algorithm will need to be rewritten to handle more edge cases which will result in much worse performance.

from czkawka.

qarmin avatar qarmin commented on September 24, 2024

All algorithms properly recognize this images as duplicates after rotating first image.

First image is horizontal image and is rotated by exif data, which is not yet supported in czkawka.

Screenshot from 2024-02-01 18-02-36

from czkawka.

janjuaasif avatar janjuaasif commented on September 24, 2024

Do I have to manually rotate all images first to get the software to recognize duplicates? How do I get around this issue?

from czkawka.

qarmin avatar qarmin commented on September 24, 2024

Yes - at least for now.

Yesterday I tested automatic rotation basing on exif data, which sometimes works, but not for this two images.

One image have broken exif data(exiftool shows warning "Skipped unknown 7 bytes after JPEG APP1 Segment") and library which I wanted to use https://crates.io/crates/kamadak-exif cannot read this data and shows error - "Truncated IFD", so currently I don't have access to any rust library which support such files.

from czkawka.

radialmonster avatar radialmonster commented on September 24, 2024

An option you could offer is to have the program rotate each image each of the 90 degree (0, 90, 180, 270) and check that this way it gets around the issue of invalid roation data, it will just go ahead and check all rotations. . This would 4x increase the time to analyze the images though, so you could have it as an option for the user to do maybe if they wanted to.

from czkawka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.