Giter Site home page Giter Site logo

Comments (1)

geo-ant avatar geo-ant commented on June 19, 2024

Hey, I've taken a look at this and I'd be willing to work on this if the maintainers deem it worthwhile. From what I can see it will require changes in at least the qdrant engine as well as the rust client.

So here's what I understand (at least I think I do, but I'll gladly take hints):

What you showed is the protobuf generated Rust code which comes from the protobuf definitions. The Range structure is used in the Condition structure, which is used in the SearchPoints structure that is passed to the search points member function of the QdrantClient. We cannot unilaterally change the layout of the Range struct because its part of the data that gets passed as a remote procedure call to the qdrant engine. From what I saw in the qdrant engine, there is a conversion layer that converts this range type to segment::types::Range. This is the type that is actually used by the engine but it also only contains Option<FloatPayloadType> fields (with FloatPayloadType = f64). So one would have to extend the Fields of this type to be able to hold either i64 or f64 which is definitely possible but will touch a lot of other code.

Hence, I would only want to do this if a maintainer is fine with that. Plus I'd like to know if I missed something and everything is much simpler after all 😁

from rust-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.