Giter Site home page Giter Site logo

Comments (3)

benjjneb avatar benjjneb commented on June 9, 2024

This would just save the user from having to re-import their reverse reads separately.

Is this really a burden though? Correct me if I'm wrong, but to achieve this, the user just has to import the reverse reads as if they were forward reads, and then run denoise-single. My initial reaction is that seems straightforward enough for the edge case of reverse reads >> forward reads.

from q2-dada2.

mestaki avatar mestaki commented on June 9, 2024

You're certainly right that it is very straightforward and it totally would be a convenience thing only in the case of using the manifest importing. Currently I would import paired-end reads and make a decision about which reads to use after looking at the quality score plots. If I wanted to use both reads or forwards only, no problem, I carry on with denoise-single/paired. If I wanted the reverse reads however, I would have to remake the manifest file to either switch the forwards with reverse labels or include the reverse reads only, then re-import. It's no priority to be sure, just saves an extra step in the case of reverse reads.

from q2-dada2.

ebolyen avatar ebolyen commented on June 9, 2024

Actually the SingleEnd types don't care if they are forward or reverse. It should be possible to simply drop the forward rows from the manifest and re-import as SingleEnd. They will be recorded as being the reverse direction, but no tooling actually cares.

If that doesn't work, then I think we should make it work better, since that's going to be a lot easier than working out a way to pass parameters to transformers.

(Right now denoise-single handles paired-end reads because there's a transformer in q2-types to convert paired-end to single-direction, where that transformer assumes you're more interested in the forward reads since it is being invoked at all.)

from q2-dada2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.