Giter Site home page Giter Site logo

Comments (3)

jonvet avatar jonvet commented on July 29, 2024

mind if I take a look at this one?

to confirm:

  • NeuralNetwork and all classes that inherit from it should have a new parameter input_gradients
  • should the current getter/setter in NeuralNetwork be deprecated?

from qiskit-machine-learning.

adekusar-drl avatar adekusar-drl commented on July 29, 2024

I don't mind, any help is appreciated.

Things to do:

  • Add input_gradient as a constructor parameter to NeuralNetwork with a default value of False. So, yes, this is the answer on the first question.
  • Verify there are getter/setter in place (as I recall there's just a getter). So, no, current getter/setter are not deprecated.
  • Remove a line in TorchConnector where input_gradients is set to True since this should be done explicitly by a user. Probably this should be mentioned in the documentation(docstrings).
  • Add a line to set input_gradients to True in the torch connector tests.
  • May be more unit tests are required, can't say now.
  • Add a reno file with the changes.

Also take a look at https://github.com/Qiskit/qiskit-machine-learning/blob/main/CONTRIBUTING.md
Probably that's it. Let me know if you have questions.

from qiskit-machine-learning.

jonvet avatar jonvet commented on July 29, 2024

cool thanks, i also have permission from my employer now, so I'll get started

from qiskit-machine-learning.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.