Comments (6)
@qmonnet Anything left after #39 and #40 are merged?
from rbpf.
Hmm maybe just one minor nit. I liked the type you declared for a verifier:
pub type Verifier = fn(prog: &[u8]) -> Result<(), Error>;
Do you think it would be worth doing the same for the helpers? So that instead of:
pub fn register_helper(&mut self,
key: u32,
function: fn (u64, u64, u64, u64, u64) -> u64)
-> Result<(), Error>
... we'd have something like:
pub fn register_helper(&mut self,
key: u32,
function: Helper) -> Result<(), Error>
(EbpfHelper
or Helper
, I don't really know what sounds best. Maybe just Helper
if people call that with the rbpf::
prefix already?)
I'm not trying to give you more work and can do it if you want :).
Apart from that, I can't think of anything in particular from my side.
from rbpf.
from rbpf.
@qmonnet Can you provide an ETA of when this can be pushed to crates.io?
from rbpf.
Just published it now :).
from rbpf.
from rbpf.
Related Issues (20)
- logo update for dark theme HOT 2
- panicked at 'attempt to add with overflow' HOT 3
- panicked at 'attempt to shift left with overflow HOT 1
- panicked at 'attempt to calculate the remainder with a divisor of zero'
- panicked at 'attempt to divide by zero'
- Fix behaviour for division/modulus by 0
- rbpf panic when running bpf_conformance with JIT HOT 1
- rbpf incorrectly rejects last instruction is not an exit
- Support atomic instructions
- Tests panick with `misaligned pointer dereference: address must be a multiple of ... but is ...` HOT 5
- Appveyor tests are flaky (Cargo fails to download dependencies) HOT 1
- Support uprobe and kprobe? HOT 2
- Segmentation fault when executing jitted program HOT 1
- Unified test suite for Cranelift, x86 JIT and interpreter
- Attempt to negate with overflow in ld_st_imm_str of disassembler
- Attempt to negate with overflow in ld_reg_str of disassembler HOT 1
- Out-of-bound memory write in the interpreter HOT 3
- Attempt to calculate the remainder with a divisor of zero for MOD32 in interpreter HOT 1
- Attempt to divide by zero in DIV32 of interpreter
- Incorrect shift implementation in the interpreter HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rbpf.