Giter Site home page Giter Site logo

Comments (14)

qoomon avatar qoomon commented on May 17, 2024 1

It was intentional. I changed the location due to problems for some plugins with relative paths (relative to pom location).
I'll add a changelog entry. I'm sorry for the inconvenience.

from maven-git-versioning-extension.

qoomon avatar qoomon commented on May 17, 2024

That was my first implementation, then I found out that some maven plugins from apache acts this way. However I can revert this change an put it the target folder again.

from maven-git-versioning-extension.

florianli avatar florianli commented on May 17, 2024

I can remember that it worked that way in a previous version. #29 looks good to me.

from maven-git-versioning-extension.

qoomon avatar qoomon commented on May 17, 2024

implemented in version v4.0.3

from maven-git-versioning-extension.

qoomon avatar qoomon commented on May 17, 2024

@florianli I've just recognised that the official maven flatten plugin put its .flattened-pom.xml next to the original pom.xml as-well.
We may should follow the standard? What do you think? actually it's quite easy to exclude all artificial pom.xml files git ignore patten would look like this .*-pom.xml

from maven-git-versioning-extension.

florianli avatar florianli commented on May 17, 2024

from maven-git-versioning-extension.

qoomon avatar qoomon commented on May 17, 2024

that would be great

from maven-git-versioning-extension.

qoomon avatar qoomon commented on May 17, 2024

I just found kinda explanation why they choose to place the modified pom file next to the original mojohaus/flatten-maven-plugin#50
I also found out that that the flatten plugin has a clean goal that is registered to the clean phase.
So I think I will revert the location back to next to the original pom file and a this clean task.
What do you think?

from maven-git-versioning-extension.

florianli avatar florianli commented on May 17, 2024

from maven-git-versioning-extension.

qoomon avatar qoomon commented on May 17, 2024

@florianli I think the problem mentioned in mojohaus/flatten-maven-plugin#50 is fixed so I will leave the pom in the target directory.

from maven-git-versioning-extension.

yankydoo avatar yankydoo commented on May 17, 2024

It seems that starting with 6.0.0 the .git-versioned-pom.xml is generated next to the pom.xml again, not in the target directory. Was this an intentional change? If so, it would be great to add it to the changelog.

from maven-git-versioning-extension.

yankydoo avatar yankydoo commented on May 17, 2024

Don't worry, no big deal. Thanks for the response!

from maven-git-versioning-extension.

tylerbenson avatar tylerbenson commented on May 17, 2024

I suggest it would be worth adding a setting for this. I agree with @yankydoo it would be nice to have it in target instead of the root. One reason is that when I'm doing find/replace operations, Intellij knows to exclude items in the target folder, but the git versioned pom shows up in those search results.

from maven-git-versioning-extension.

qoomon avatar qoomon commented on May 17, 2024

There are related issues in the flatten pom plugin, see:

from maven-git-versioning-extension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.