Comments (14)
It was intentional. I changed the location due to problems for some plugins with relative paths (relative to pom location).
I'll add a changelog entry. I'm sorry for the inconvenience.
from maven-git-versioning-extension.
That was my first implementation, then I found out that some maven plugins from apache acts this way. However I can revert this change an put it the target folder again.
from maven-git-versioning-extension.
I can remember that it worked that way in a previous version. #29 looks good to me.
from maven-git-versioning-extension.
implemented in version v4.0.3
from maven-git-versioning-extension.
@florianli I've just recognised that the official maven flatten plugin put its .flattened-pom.xml
next to the original pom.xml
as-well.
We may should follow the standard? What do you think? actually it's quite easy to exclude all artificial pom.xml
files git ignore patten would look like this .*-pom.xml
from maven-git-versioning-extension.
from maven-git-versioning-extension.
that would be great
from maven-git-versioning-extension.
I just found kinda explanation why they choose to place the modified pom file next to the original mojohaus/flatten-maven-plugin#50
I also found out that that the flatten plugin has a clean goal that is registered to the clean phase.
So I think I will revert the location back to next to the original pom file and a this clean task.
What do you think?
from maven-git-versioning-extension.
from maven-git-versioning-extension.
@florianli I think the problem mentioned in mojohaus/flatten-maven-plugin#50
is fixed so I will leave the pom in the target directory.
from maven-git-versioning-extension.
It seems that starting with 6.0.0 the .git-versioned-pom.xml is generated next to the pom.xml again, not in the target directory. Was this an intentional change? If so, it would be great to add it to the changelog.
from maven-git-versioning-extension.
Don't worry, no big deal. Thanks for the response!
from maven-git-versioning-extension.
I suggest it would be worth adding a setting for this. I agree with @yankydoo it would be nice to have it in target
instead of the root. One reason is that when I'm doing find/replace operations, Intellij knows to exclude items in the target
folder, but the git versioned pom shows up in those search results.
from maven-git-versioning-extension.
There are related issues in the flatten pom plugin, see:
- mojohaus/flatten-maven-plugin#53
- mojohaus/flatten-maven-plugin#94
As long as there is no real solution I'll will stay with the current solution, alike the flatten pom plugin behaviour.
from maven-git-versioning-extension.
Related Issues (20)
- Artifact of tag gets "-SNAPSHOT" added HOT 6
- versions 8.0.0 and newer not working with Maven 3.6.3 Java 11/17 HOT 8
- An internal error occurred during: "Updating Maven Project". HOT 8
- Allow combined overwrite and default value for properties HOT 1
- Support overwriting properties defined in parent HOT 1
- On Jenkins maven-git-versioning-extension runs 2x for module but on local dev machine only once? HOT 12
- Leading or Trailing whitespace in profile 'id' element causes NPE in maven-git-versioning-extension HOT 3
- no tags detected in git worktree HOT 14
- describeTagPattern-Example in docs suggests behaviour not actually implemented
- Runtim exception in azure devops pipeline
- Support valid semver versions HOT 4
- [WARNING] skip - project is not part of a git repository HOT 1
- 'describe.tag' not seeing tags in Jenkins CI environment HOT 1
- exclude module in multi-module project HOT 1
- Select newest/highest version tag for building HOT 1
- Github-Repository not up-to-date? HOT 2
- Describe should not return current tag from describe HOT 3
- Match a tag instead of branch HOT 5
- Does not work with polyglot-maven-extension HOT 4
- [v9.7.0] Missing transitive dependencies in multi-module project when modules are excluded and resolved version is 0.0.0-SNAPSHOT
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from maven-git-versioning-extension.