New buildMailable Implementation Fails to Invoke build Method, Breaking Edit and Preview Functionality

[enact-on]

New buildMailable Implementation Fails to Invoke build Method, Breaking Edit and Preview Functionality

[enact-on]

@ReeceM
As mentioned above, currently we are using the latest version because we have moved to Laravel 10

But v2.x and v3.x code looks good.

Change occurred in v4.x , i've shared the code change in original comment.

[enact-on]

laravel-mail-editor/src/MailEclipse.php

Line 807 in b886a16

return app()->call([self::handleMailableViewDataArgs($instance), 'build']);

Looks in v3 also has build method in it. But in v4 its not calling it anymore.

[ReeceM]

Hi @enact-on, sorry there is a bug that is breaking your app. What version are you using?

[enact-on]

Hi @ReeceM

Did you get to review this? "build" method is no longed called in v4.

This is unexpected change in v4, its breaking change for our use case.

[ReeceM]

@enact-on Unfortunately I work in the week and have commitments on some of the other days.

What I just want to ask do your markdown mails work with the latest version of laravel tho, not with the package?

[enact-on]

Yes , our mailables works fine in all Laravel v7,8,9,10.

Because Mailable, the build method gets called by Laravel so it works fine.
In case of package v4, build method isn't called, hence it can't preview or edit template.

Hope this answers.

Thanks for your support, totally understandable your commitment.