lsp tsserver breaking functionality

[quangnguyen30192]

lsp tsserver breaking functionality

[smjonas]

Ok this is weird. Did I get this correct: it does not happen when you have disabled cmp-nvim-ultisnips and only enabled UltiSnips? Or does it also happen then? Because in that case it is probably an UltiSnips issue.

[Astrantia]

Ok this is weird. Did I get this correct: it does not happen when you have disabled cmp-nvim-ultisnips and only enabled UltiSnips? Or does it also happen then? Because in that case it is probably an UltiSnips issue.

I didn't think to do that, but correct, it also happens when i disable cmp-nvim-ultisnips, so it is an UltiSnips issue. Should I close this issue and open one in UltiSnips? But they don't care much about neovim over there from what I remember

[Astrantia]

It's also strange because this doesn't happen with other language servers, so there's something specific with tsserver that does it. I haven't configured tsserver with extra configs.

[smjonas]

I didn't think to do that, but correct, it also happens when i disable cmp-nvim-ultisnips, so it is an UltiSnips issue. Should I close this issue and open one in UltiSnips? But they don't care much about neovim over there from what I remember

Yeah that's true. I will try to reproduce this first to be sure it also occurs for me.

[smjonas]

I can reproduce this by typing '${|}' in a .ts file (where | is the cursor) and hitting Tab. However, uninstalling tsserver does not help but removing cmp-nvim-ultisnips does. So it is indeed a bug in the new cmp-nvim-ultisnips keybindings.

Update: it also appears when cmp-nvim-ultisnips is disabled (don't know why I thought it didn't happen then), so it's not a cmp-nvim-ultisnips bug. Investigating...

[smjonas]

This might be a nvim-cmp issue as I tested it with a minimal config. I will continue later.
We should confirm this, then create a bug report on the cmp repo.

[Astrantia]

I can reproduce this by typing '${|}' in a .ts file (where | is the cursor) and hitting Tab. However, uninstalling tsserver does not help but removing cmp-nvim-ultisnips does. So it is indeed a bug in the new cmp-nvim-ultisnips keybindings.

Update: it also appears when cmp-nvim-ultisnips is disabled (don't know why I thought it didn't happen then), so it's not a cmp-nvim-ultisnips bug. Investigating...

And from your experience it is not tied to enabling/disabling tsserver? Fixing what you found might fix the one I'm facing as well.

[smjonas]

Yes, I uninstalled tsserver and it still occurred. I now reported it on the cmp repo.

[smjonas]

Seems like hrsh7th could not reproduce it... Are you on Linux by any chance? I also could not reproduce it anymore after deleting the other plugins from my packer directory. Also could you share your plugin list so that we can narrow down which plugin(s) might cause this (that we are both using)?

[Astrantia]

Seems like hrsh7th could not reproduce it... Are you on Linux by any chance? I also could not reproduce it anymore after deleting the other plugins from my packer directory. Also could you share your plugin list so that we can narrow down which plugin(s) might cause this (that we are both using)?

I have bunch of plugins installed, so I'll try to narrow down what plugin or setting is interfering here, but it's definitely has to do with tsserver, because enabling/disabling it makes my problem go away and come back

[smjonas]

I found the cause for this issue. It is caused by vim-snippets, specifically by this javascript snippet (link):

snippet ${
	${${1}}${0}

(typescript snippets extend from javascript snippets)

Honestly, I think this snippet should be removed from vim-snippets since it doesn't seem that useful and causes issues when expanding other snippets. However, I am not sure if it's worth opening a PR there since the plugin doesn't seem too well maintained currently.

But please feel free (you or someone else that comes across this) to open an issue there or a PR! :)