Giter Site home page Giter Site logo

Comments (6)

twiecki avatar twiecki commented on July 21, 2024

CC @ahgnaw @abhijeetkalyan

from empyrical.

analicia avatar analicia commented on July 21, 2024

Great idea, that way we can simplify the API.

from empyrical.

twiecki avatar twiecki commented on July 21, 2024

Glad you like it, what do you think of the two options? I kinda like the first one for its simplicity, but the other one has it's pros too.

from empyrical.

ssanderson avatar ssanderson commented on July 21, 2024

I would be careful about enshrining a canonical definition of what "daily" means. There are ~252 trading days in the NYSE calendar, but Zipline already supports calendars other than NYSE, which have different numbers of trading days.

from empyrical.

analicia avatar analicia commented on July 21, 2024

I have a preference towards the second one. Instead of having users write empyrical.function(returns, empyrical.DAILY) they could write empyrical.function(returns, 'daily')

from empyrical.

twiecki avatar twiecki commented on July 21, 2024

@ssanderson Since it's a free parameter users can pass in whatever is appropriate for the exchange they are trading. But we should definitely make that clear in the doc-string that the default is relative to NYSE.
@ahgnaw Yep, that's fine with me.

from empyrical.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.