Remote Desktop Crashes - Multi-Monitors

[quasar]

Remote Desktop Crashes - Multi-Monitors

I noticed this happening as well. I believe it has to do with resolution. Is one of your monitors a different resolution than the other? At 1920x1080 on both of my monitors switching between the two is fine for me, and doesn't crash. When I change the resolution while the Remote Desktop is running the client crashes

[yankejustin]

I do have monitors with different resolutions. (1920x1080) and (1080x760). Perhaps that means that https://github.com/MaxXor/xRAT/blob/master/Client/Core/Commands/CommandHandler.cs#L226 could have something to do with this issue.

[yankejustin]

Accidentally closed! Sorry!

https://github.com/MaxXor/xRAT/blob/master/Client/Core/Commands/CommandHandler.cs#L236-L239

The UnsafeStreamCodec class is throwing an exception "Bitmap width/height are not equal to previous bitmap"

Perhaps a try/catch/finally scenario could be of use? I'm not too sure how to handle it properly

[MaxXor]

Can you check if the fix from this branch is working for you?
https://github.com/MaxXor/xRAT/tree/remote-desktop-fix

No it does not.

https://github.com/MaxXor/xRAT/blob/master/Client/Core/Commands/CommandHandler.cs#L236-L239

The CodeImage method throws an exception. I think adding a try/catch around this method call and setting the StreamCodec to null in the catch block, then sending a packet with a flag to tell the server to reset the stream and create a new Codec class might do the trick.

[MaxXor]

I just changed the monitor resolution of my second monitor to 1080x760 and no exception occured. I followed the steps from yankejustin to reproduce this issue.

My apologies, this DID fix the issue when switching between monitors with two different resolutions.

The issue I was having was changing my resolution on the other monitor while the Remote Desktop was running, which was causing the Codec class to throw the exception.

[MaxXor]

Alright! :) Do you think the client should also handle the situation when someone changes the resolution?

I think it should since its possible and bound to happen. Just another little thing to fix to have a bug-free application xD

[MaxXor]

Yes, hehe. :D