Giter Site home page Giter Site logo

propagate_mask about astroalign HOT 2 CLOSED

yas-nakajima avatar yas-nakajima commented on July 26, 2024
propagate_mask

from astroalign.

Comments (2)

martinberoiz avatar martinberoiz commented on July 26, 2024

Hi,

Sorry for the late reply. I looked into it and I found the source of the error. Turns out that when you apply the transformation to the mask the one center True pixel in the mask is smeared on its neighbor pixels. This is the transformation of the mask before discretizing it back into True/False.

array([[0.  , 0.  , 0.  , 0.  , 0.5 ],
       [0.  , 0.25, 0.25, 0.  , 0.5 ],
       [0.  , 0.25, 0.25, 0.  , 0.5 ],
       [0.  , 0.  , 0.  , 0.  , 0.5 ],
       [0.5 , 0.5 , 0.5 , 0.5 , 0.75]], dtype=float32)

The threshold value that astroalign uses to consider a pixel to be on the mask is if it's larger than 0.4. All the 0.25 don't make the cut and the hole is lost.

This is probably a not so common case, but I wonder if the threshold should be more aggressive and set it to 0.1 for example. Or even just do a > 0. The 0.4 was there to avoid too-soft edges.

from astroalign.

yas-nakajima avatar yas-nakajima commented on July 26, 2024

Thank you for your reply.
Now I understand the specification for the threshold.

from astroalign.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.