junit / xunit issue

[stdweird]

junit / xunit issue

[stdweird]

following patch was applied to the TAP::Harness::Junit module (which was installed using cpan, and is local to jenkins) to force the reported time output to 3 digits after comma, to make the junit_output.xml "valid" again.
TAP::Harness::Junit hasn't seen any development in years, so i think this patch is safe; and i also assume we can't upstream the patch as it way too specific (and feels like it works around some xunit issue about xunit being way to restricted)

--- perl/lib/perl5/TAP/Harness/JUnit.pm.orig	2018-07-20 12:47:24.055481018 +0200
+++ perl/lib/perl5/TAP/Harness/JUnit.pm	2018-07-20 12:49:41.135478156 +0200
@@ -199,6 +199,7 @@
 
 	my $time = $parser->end_time - $parser->start_time;
 	$time = 0 if $self->{__notimes};
+	$time = sprintf("%.3f", $time);
 
 	# Get the return code of test script before re-parsing the TAP output
 	my $badretval = $parser->exit;
@@ -243,6 +244,7 @@
 
 		my $time = $result->{__end_time} - $result->{__start_time};
 		$time = 0 if $self->{__notimes};
+		$time = sprintf("%.3f", $time);
 
 		# Counters
 		if ($result->type eq 'plan') {

[stdweird]

@jrha @jouvin @ned21 tests shouldn't be failing anymore (but you might need to rerun them)

[jrha]

@stdweird thanks for digging into this and sorting it out