Comments (8)
I don't think this is the right thing to do, I think they should simply be deleted in a later release.
They should have been superseded by the new templates @brunocanning produced.
The majority of the templates under legacy refer to network drivers rather than specific cards, which is not useful. The templates under the vendor namespace should refer to models of network cards.
from template-library-standard.
I missed that the new templates were basically matching the old ones... My concern, based on my previous experience with legacy
things, is that this is always hard to decide to delete it... And I don't see the real added value of creating this nic/legacy
rather than just adding the deprecation to the original template under nic
. At the end this is just adding to the mess, creating new templates that may appear legitimate to use. My preference would have been one of the following approaches:
- Keep the original template at the original place and add the deprecation warning: this will make removal easier
- Just remove the original templates from the release: sites could always keep the previous ones. But this is probably not the right approach on the long run, as there will be no deprecation warning to push the site to migrate.
Looking at the contents of nic/legacy
I don't have the feeling that it will be that easy to find the replacement in the vendor-based templates. May be a small table somewhere on our web site with the usual "mapping" may help... I don't know if it makes sense...
from template-library-standard.
An alternative would be to rename legacy
to by_driver
or something similar.
from template-library-standard.
I should also add that the time for review is before PRs are merged, not after.
#69 was open for almost four months which should have been plenty of time.
from template-library-standard.
@jrha I completely agree and I should apologize for overlooking this problem the first time I looked at the PR.... And I was away when the last comments before the merge were done. Anyway the PR does nothing wrong and my suggestion is just a proprosed enhancement!
from template-library-standard.
BTW, suggestion to use by_driver
rather than legacy
(#77 (comment)) is fine with me and may be better reflects that these new templates (under by_driver
) are legitimate to use. Just the ones under nic/
are deprecated.
from template-library-standard.
Whilst most of the legacy templates are named by driver, some are actually named by model, e.g. mcp55 and bcm5700, both of which have new, expanded templates under hardware/nic/nvidia/
and hardware/nic/broadcom/
, respecively. In these two cases, the original template was detailed enough and I had access to a host fitted with these nics in order to construct new templates. For these reasons, I thought that moving all the old templates to hardware/nic/legacy/
was easier and cleaner. HTH.
from template-library-standard.
@brunocanning to be clear, I think you did a great job! My point is just to enhance it a little bit as I have the concerns expressed above with anything named legacy
but intended to last quite some time... by_driver
seems to me a little bit better. I'd say that if an old templatehas a matching by-vendor one, even if it is not exactly the same (for example the name
attribute is not worded the same way), the deprecated template should include this one and none should be created in by_driver
.
from template-library-standard.
Related Issues (20)
- hardware/cpu/intel add embedded cpus HOT 2
- cvmfs client is not configured correctly HOT 1
- frontier file name 'customized.sh' HOT 1
- way to set lvm raid type when vol type = lvm
- Clean-up os/kernel_version_arch to remove all the errata management
- frontier feature outdated? HOT 5
- Use metaconfig for Pakiti 3 support
- New frontier feature needed
- cvmfs 2.1.20 rpms
- Passing mount and mkfs options to filesystem/config HOT 1
- features/cvmfs/client does not compare versions correctly
- cvmfs: use metaconfig and make the code more generic
- cvmfs: specify which client version to be installed
- Generation of DISK_VOLUME_PARAMS will not work with panc 10.3
- 16.8.0-rc1: wrong namespace for some network cards and CPUs HOT 1
- nic/by_driver/bnx2* templates: improperly designated as Qlogic drivers HOT 4
- 16.10.0-rc1 fetch-crl/config: function matches used instead of match HOT 1
- filesystem/config: add esp flag to a UEFI boot partition HOT 1
- Change value of 'model' field to real model name in CPU templates HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from template-library-standard.