Importing issue

[quentin-ol]

Importing issue

[quentin-ol]

Sorry, I'm kinda swamped today. I will look into this tomorrow.

So, if I understand well (otherwise correct me):

• this issue is due the lack of AOT support in angular2-openlayers.
• angular-cli beta 22 adopted AOT and broke the import (wild guess there).
• you're workin on a PR to make angular2-openlayers AOT-compliant (friendly ?)

Thanks again, your help is much appreciated !

[FallenRiteMonk]

You are correct in all 3 points, with the little extra to say that beta 22 didn't adopt AOT but made it default (on purpose or not) angular/angular-cli#3368.

Still I think it is important to generally be AOT compliant and also angular-cli complient, since I thing/guess the cli will be the future default boilerplate for angular2 apps and AOT because I'd rater decline this library then AOT since it gave me a extreme performance boost on one of my apps (Loading time form 10sec to 2sec, with no other changes then just compiling using AOT)

[quentin-ol]

I believe this issue is solved, could you double-check and close it ?

[FallenRiteMonk]

Sorry I was on the road for a few days, so I couldn't test. I saw you merged everything so I tried importing version 0.4.1 from npm and tried running it with aot, but the map stayed blank.

I don't know exactly what the problem now is, but I'll have a look and let you know. In the mean while could you please tell me exactly what procedure you run in order to publish on npm.

[quentin-ol]

I'm using the npm publish command.
The complete workflow is given here: https://docs.npmjs.com/getting-started/publishing-npm-packages

[FallenRiteMonk]

Do you have to run npm run prepublish befror npm publish or is that automatically done like with npm pack?

[quentin-ol]

Hey!
No need to run prepublish prior to npm publish as it takes care of it. Here is the output of npm publish:

$[edited...]npm publish

> [email protected] prepublish /[edited...]/angular2-openlayers
> ngc

+ [email protected]

[quentin-ol]

Closing as angular2-openlayers is now AOT compliant.
Feel free to reopen if need be