Comments (4)
and when you then use the list at a completely unrelated place you suddenly get an exception.
This would not change by passing the type class to the constructor.
The point of having generics is that the type is already ensured at compile time, therefore the actual solution would be to remove all convenience methods that add values directly to a ListTag
like e.g. ListTag#addString()
. I made a compromise by having generic methods on the one hand that use the Tag classes for type safety and on the other hand having convenience methods that are consistent with the other structure tags (CompoundTag
and StructTag
).
from nbt.
When the type is passed to the constructor it would already be initialized when you try to add an element of the incorrect type.
Then the special case in checkValue
would have to be removed
NBT/src/main/java/net/querz/nbt/ListTag.java
Line 335 in 947c750
And the modification of the tag type in the add method
NBT/src/main/java/net/querz/nbt/ListTag.java
Lines 88 to 89 in 947c750
Additionally it would probably be good to have a protected or private method addUnchecked(Tag<?>)
to prevent all the casts and SuppressWarnings
annotations for the type specific methods.
from nbt.
I'll have too look into how deserialisation works with that, because the type of the list is read after it's been instantiated.
from nbt.
An empty ListTag can now only be untyped if created using the protected static method ListTag.createUnchecked()
. ListTag#getTypeClass()
will return EndTag.class
if the type is not specified and the ListTag is empty. From this untyped state, the LisTag can only ever change it's type once using any of the set()
, add...()
or as...List()
methods. A ListTag of type EndTag can not be created anymore. If attempting to do so it will throw an IllegalArgumentException
.
#clone()
, #equals()
and #hashCode()
have been adjusted to include the type class in their actions.
The ListTag constructor now needs a mandatory type class additionally to the ListTag generic type specification. The type class passed to the constructor must be of the exact same type as the generic type.
ListTag<StringTag> s = new ListTag<>(StringTag.class);
ListTag<ListTag<?>> l = new ListTag<>(ListTag.class);
from nbt.
Related Issues (20)
- This repo doesnt write valid NBT for MCA HOT 1
- Populating a new chunk from scratch results in an ArrayIndexOutOfBoundsException HOT 4
- Please merge the little-endian-io-SNAPSHOT branch over the recommended public branch(es) HOT 1
- Limited height on write region file
- Upload releases to maven central HOT 1
- Update README
- Strings with the literal values "true" and "false" are mistaken with bytes when written and parsed from SNBT. HOT 1
- Charset problem while recreating Minecraft servers.dat file HOT 1
- StringOutOfBoundsIndexException issue, and ParseException suggestion
- Suggestion: Block State Parser
- Cast exception while reading mca file
- How do I serialize an NBT compound?
- 1.18 Support? HOT 3
- ListTag Double issue HOT 1
- .0 is ignored in doubles in toSNBT
- "cannot cast ListTag<ByteTag> to ListTag<CompoundTag>" when open Entities tag HOT 1
- Support for POI mca files?
- CompoundTag .get method returning null with valid key
- GZIP streams are not closed, causing errors when extracting.
- data does not contain Level tag fix HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nbt.