Giter Site home page Giter Site logo

Remove Tag.getEmptyValue() about nbt HOT 3 CLOSED

querz avatar querz commented on June 12, 2024
Remove Tag.getEmptyValue()

from nbt.

Comments (3)

Querz avatar Querz commented on June 12, 2024 1

I fixed these so far. ObjectTag#compareTo calls a compareTo method if the values of both ObjectTags implement Comparable. If not, it checks if both values are the same. It returns 1 if the value of this ObjectTag is null but the value of the other isn't and -1 if the value of the other ObjectTag is null but the value of this ObjectTag isn't.

Currently i simply return 0 if none of the above conditions match.

from nbt.

Querz avatar Querz commented on June 12, 2024

See #27
I also made the Tag() constructor protected so each Tag implementation must specify their own no-args constructor and set their default value. If the only action inside this no-args constructor is a call to Tag(), the value will be null. This might be needed for custom tags (e.g. ObjectTag).

from nbt.

Marcono1234 avatar Marcono1234 commented on June 12, 2024

Maybe it would be better to have a validateValue method which by default prevents null and then have ObjectTag override it.

Also there are currently multiple problems with ObjectTag:

  • new ObjectTag().setValue(null) throws NPE
  • ObjectTag#hashCode throws NPE for null values
  • ObjectTag#clone should not catch NPE, instead null check should be done
  • ObjectTag#compareTo considers a other null value equal to this, even if this value might not be null

from nbt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.