Comments (3)
I fixed these so far. ObjectTag#compareTo
calls a compareTo
method if the values of both ObjectTag
s implement Comparable
. If not, it checks if both values are the same. It returns 1
if the value of this ObjectTag
is null
but the value of the other isn't and -1
if the value of the other ObjectTag
is null
but the value of this ObjectTag
isn't.
Currently i simply return 0
if none of the above conditions match.
from nbt.
See #27
I also made the Tag()
constructor protected so each Tag
implementation must specify their own no-args constructor and set their default value. If the only action inside this no-args constructor is a call to Tag()
, the value will be null
. This might be needed for custom tags (e.g. ObjectTag
).
from nbt.
Maybe it would be better to have a validateValue
method which by default prevents null
and then have ObjectTag
override it.
Also there are currently multiple problems with ObjectTag
:
new ObjectTag().setValue(null)
throws NPEObjectTag#hashCode
throws NPE for null valuesObjectTag#clone
should not catch NPE, instead null check should be doneObjectTag#compareTo
considers a othernull
value equal to this, even if this value might not benull
from nbt.
Related Issues (20)
- This repo doesnt write valid NBT for MCA HOT 1
- Populating a new chunk from scratch results in an ArrayIndexOutOfBoundsException HOT 4
- Please merge the little-endian-io-SNAPSHOT branch over the recommended public branch(es) HOT 1
- Limited height on write region file
- Upload releases to maven central HOT 1
- Update README
- Strings with the literal values "true" and "false" are mistaken with bytes when written and parsed from SNBT. HOT 1
- Charset problem while recreating Minecraft servers.dat file HOT 1
- StringOutOfBoundsIndexException issue, and ParseException suggestion
- Suggestion: Block State Parser
- Cast exception while reading mca file
- How do I serialize an NBT compound?
- 1.18 Support? HOT 3
- ListTag Double issue HOT 1
- .0 is ignored in doubles in toSNBT
- "cannot cast ListTag<ByteTag> to ListTag<CompoundTag>" when open Entities tag HOT 1
- Support for POI mca files?
- CompoundTag .get method returning null with valid key
- GZIP streams are not closed, causing errors when extracting.
- data does not contain Level tag fix HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nbt.