Comments (4)
We could just remove that print
here, or replace it by a logging.debug
.
from quic-interop-runner.
These are all pyshark errors, which are thrown because a pcap contains a partial packet. I don't see any way to disable that check / error message. Maybe it would be a good idea to simply hide all pyshark errors.
FWIW, it's also polluting the output on GitHub Actions: https://github.com/marten-seemann/quic-interop-runner/actions/runs/237401524.
from quic-interop-runner.
Can you just try/catch and ignore them all? Maybe have a -verbose
command line option to actually print them out in case you need to see them later?
from quic-interop-runner.
Removing all the pyshark output definitely helped, but I'd like a bit more. For instance, take this output:
Saving logs to ./logs.
Expected exactly 1 handshake. Got: 3
Expected at least 2 ClientHellos. Got: 0
Expected exactly 2 handshake. Got: 4
Missing files: ['dleshiaewf']
Expected 50 handshakes. Got: 46
Missing files: ['wjrfeuzvmi']
Expected 50 handshakes. Got: 48
Missing files: ['arwuloafqh']
Missing files: ['nxgwhmfkkg']
Missing files: ['htjehiteld']
Run took 0:11:58.096941
Server: quant. Client: msquic. Running test case: handshake
Server: quant. Client: msquic. Running test case: transfer
Server: quant. Client: msquic. Running test case: longrtt
Server: quant. Client: msquic. Running test case: chacha20
Server: quant. Client: msquic. Running test case: multiplexing
Server: quant. Client: msquic. Running test case: retry
Server: quant. Client: msquic. Running test case: resumption
Server: quant. Client: msquic. Running test case: zerortt
Server: quant. Client: msquic. Running test case: http3
Server: quant. Client: msquic. Running test case: blackhole
Server: quant. Client: msquic. Running test case: handshakeloss
Server: quant. Client: msquic. Running test case: transferloss
Server: quant. Client: msquic. Running test case: handshakecorruption
Server: quant. Client: msquic. Running test case: transfercorruption
Server: quant. Client: msquic. Running test case: goodput
Server: quant. Client: msquic. Running test case: crosstraffic
+--------+------------------+
| | quant |
+--------+------------------+
| msquic | H |
| | Z3C20 |
| | LRRDCSMC1L1BC2L2 |
IMO, things would be a lot better if the output was modified so that it prints which test is being run, then any errors, and then the final result. Something more like:
Saving logs to ./logs.
Server: quant. Client: msquic. Running test case: handshake
Success
Server: quant. Client: msquic. Running test case: transfer
Expected exactly 1 handshake. Got: 3
Failure
Server: quant. Client: msquic. Running test case: longrtt
Expected at least 2 ClientHellos. Got: 0
Failure
...
fyi, @marten-seemann I don't seem to have the permissions to reactivate the issue.
from quic-interop-runner.
Related Issues (20)
- Q/A: Please share commands used internally HOT 4
- docker pulling s2n-quic regularly fails HOT 6
- consider removing quant HOT 3
- move repo to a separate GitHub org HOT 4
- Need to update Wireshark/TShark cache version HOT 2
- key update test seems broken
- docker pull for nginx is failing the build: AWS container registry HOT 2
- Drop implementations that haven't been updated HOT 5
- xquic is taking >8h to run tests
- Add option to generate Markdown `prettytable`s
- ECN test shouldn't be counting marks from packets that cannot be decrypted HOT 2
- Everyone fails the amplification test at the moment? HOT 1
- "This event loop is already running" HOT 2
- What role does the VERSION environment variable play in the tests? HOT 6
- Automatically mark as unsupported HOT 5
- Test results exported to result.json don't map to the correct server/client HOT 2
- feature request: add openssl quic (openssl 3.2+) HOT 1
- EIO on sendmsg with GSO HOT 2
- zerortt test counts 1-RTT traffic from first connection HOT 2
- No pcaps when platforms don't match
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quic-interop-runner.