Giter Site home page Giter Site logo

Comments (6)

Ralith avatar Ralith commented on August 20, 2024 1

The README does state that compose v2 is unsupported. I wish the error was more self-explanatory, but now that this issue exists it should show up in search results at least.

from quic-interop-runner.

MarcoPolo avatar MarcoPolo commented on August 20, 2024

I had the same issue here, but worked around it with this patch:

diff --git a/interop.py b/interop.py
index 4dea51d..29c6385 100644
--- a/interop.py
+++ b/interop.py
@@ -130,6 +130,7 @@ class InteropRunner:
             "DOWNLOADS=" + downloads_dir.name + " "
             'SCENARIO="simple-p2p --delay=15ms --bandwidth=10Mbps --queue=25" '
             "CLIENT=" + self._implementations[name]["image"] + " "
+            "SERVER=" + self._implementations[name]["image"] + " "
             "docker-compose up --timeout 0 --abort-on-container-exit -V sim client"
         )
         output = subprocess.run(
@@ -152,6 +153,7 @@ class InteropRunner:
             "CLIENT_LOGS=/dev/null "
             "WWW=" + www_dir.name + " "
             "DOWNLOADS=" + downloads_dir.name + " "
+            "CLIENT=" + self._implementations[name]["image"] + " "
             "SERVER=" + self._implementations[name]["image"] + " "
             "docker-compose up -V server"
         )

I'm guessing the docker compose format changed slightly from when this first created.

from quic-interop-runner.

Ralith avatar Ralith commented on August 20, 2024

Ah, yeah, switching to docker-compose 1.x got past this.

from quic-interop-runner.

MarcoPolo avatar MarcoPolo commented on August 20, 2024

I think we should reopen unless this project is pinned to compose v1

from quic-interop-runner.

marten-seemann avatar marten-seemann commented on August 20, 2024

#314 is an attempt to migrate to compose v2. It works locally on my machine. @Ralith would you mind giving the PR a try?

from quic-interop-runner.

marten-seemann avatar marten-seemann commented on August 20, 2024

I believe this has been resolved now that we support docker compose v2 (#333). Sorry that fixing this took so long!

Please reopen if you still run into this issue.

from quic-interop-runner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.