Giter Site home page Giter Site logo

Comments (3)

Lysxia avatar Lysxia commented on July 22, 2024

It seems fine to enable it.

We can just make a new release with the patch though, right?

from quickchick.

Chobbes avatar Chobbes commented on July 22, 2024

Putting it in new releases would be good, I think!

I was concerned that the old versions will still need to be patched within nix --- nix selects a default version of QC based on the version of Coq in use, so old versions will still be broken if you're on Coq <8.14 or whatever. But I think you're right that manually patching these versions would be best. Updating the old releases would break more things (in particular, nix relies on hashes of the releases to make sure you fetch the right things, so updating the old releases would break everything...)

I already manually patch things here: https://github.com/NixOS/nixpkgs/pull/164664/files so I personally don't think that's a problem.

I'm wondering if @vbgl has any opinion.

P.S., I've noticed that 1.6.0 and 1.6.1 for Coq 8.15 don't have official releases on github yet (https://github.com/QuickChick/QuickChick/releases)

Is that expected? If so could we add -use-ocamlfind to those before a release is done, or are they already on opam?

from quickchick.

Lysxia avatar Lysxia commented on July 22, 2024

Patching things downstream until the next release (which should work for even Coq 8.11) sounds like a good plan.

As far as opam is concerned, the git tag is the release (so 1.6.0 and 1.6.1 are already out). The "Release" feature on Github is not really meaningful for libraries, apart from a bit of publicity. It's more useful for end-user programs because binaries can be attached. It's just that Yishuai has the habit of making those "Github releases", and I don't.

from quickchick.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.