Comments (3)
It seems fine to enable it.
We can just make a new release with the patch though, right?
from quickchick.
Putting it in new releases would be good, I think!
I was concerned that the old versions will still need to be patched within nix --- nix selects a default version of QC based on the version of Coq in use, so old versions will still be broken if you're on Coq <8.14 or whatever. But I think you're right that manually patching these versions would be best. Updating the old releases would break more things (in particular, nix relies on hashes of the releases to make sure you fetch the right things, so updating the old releases would break everything...)
I already manually patch things here: https://github.com/NixOS/nixpkgs/pull/164664/files so I personally don't think that's a problem.
I'm wondering if @vbgl has any opinion.
P.S., I've noticed that 1.6.0 and 1.6.1 for Coq 8.15 don't have official releases on github yet (https://github.com/QuickChick/QuickChick/releases)
Is that expected? If so could we add -use-ocamlfind
to those before a release is done, or are they already on opam?
from quickchick.
Patching things downstream until the next release (which should work for even Coq 8.11) sounds like a good plan.
As far as opam is concerned, the git tag is the release (so 1.6.0 and 1.6.1 are already out). The "Release" feature on Github is not really meaningful for libraries, apart from a bit of publicity. It's more useful for end-user programs because binaries can be attached. It's just that Yishuai has the habit of making those "Github releases", and I don't.
from quickchick.
Related Issues (20)
- Warn when calling `make` with OCaml/Coq versions different from versions used for `make compat`
- FuzzChick status HOT 2
- Do we need ocamlbuild?
- Derive fails for records and variants HOT 1
- Derive for inductive types with non-type parameters HOT 1
- Dune-based builds fail with 'I cannot find the root of the current workspace/project' HOT 8
- Derive ArbitrarySizedSuchThat failure
- Extract Constant defNumShrinks not working HOT 1
- Document that Z is extracted to either int or bigint depending on Coq version HOT 1
- Bad installation target for quickChick tool HOT 4
- [Compilation Error] Reference uncurry was not found HOT 4
- Please create a tag for Coq 8.16 in Coq Platform 2022.09 HOT 3
- Can't check conjecture, error says "pattern matching failed" HOT 2
- Specify a directory for extracted sources other than `/tmp` HOT 3
- Using QuickChick Inside OCaml As A Library
- Derive not unfolding definitions enough HOT 3
- Please create a tag for Coq 8.17 in Coq Platform 2023.03 HOT 15
- Fix tests HOT 1
- Spurious test error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickchick.