[Bug] denotationChar becomes null in mention

[quill-mention]

[Bug] denotationChar becomes null in mention

[MadSpindel]

Yes, thank you @cwhite-connectfirst! I will release this as v2.0.0

[MadSpindel]

Ping @cwhite-connectfirst

[cwhite-connectfirst]

@webmarket7 good catch. I'll submit a PR for this shortly.

[cwhite-connectfirst]

@MadSpindel Just curious - was there an intent to support a custom renderList function? I see that we're storing a bound reference to renderList on the options object (https://github.com/afconsult/quill-mention/blob/master/src/quill.mention.js#L29). It doesn't seem like that was the case, but I wanted to check with you first. renderList isn't mentioned in the documentation as a valid option right now. Also, if a custom renderList function is supposed to be a supported feature, it's not working correctly right now, since we're not referencing the renderList function stored on the options object when calling source (https://github.com/afconsult/quill-mention/blob/master/src/quill.mention.js#L244).

Personally, I don't think it makes much sense to let users override the renderList function with their own definition, since renderList is responsible for modifying instance properties. I'm going to submit this PR with renderList removed from the options object, but if you think it should be a valid option, let me know and I can revert that change from my PR.

EDIT: Just realized why we're attaching renderList to this.options. The intended use is to call this.renderList(...) when a user wants to pass in data to the component. In the future, it might make sense to only pass a reference to renderList into source, instead of depending on renderList being present on this.

[cwhite-connectfirst]

PR #17

[MadSpindel]

@cwhite-connectfirst Yeah, I think we should remove renderList from this.options and only pass the reference. Is it something you want to do in your pull request now or should I merge it as is?

[cwhite-connectfirst]

@MadSpindel I can do that in my PR, since it's an easy change. It also cleans up my fix a bit.

[cwhite-connectfirst]

Just pushed those changes

Edit: Hopefully it's obvious, but removing the ability to reference renderList on this inside of the source function is a breaking change. Just thought I'd mention it here for more visibility.