Giter Site home page Giter Site logo

Use String as Event Id about android-week-view HOT 8 CLOSED

quivr avatar quivr commented on July 29, 2024 3
Use String as Event Id

from android-week-view.

Comments (8)

ShivamDev31 avatar ShivamDev31 commented on July 29, 2024

Just change the id in WeekView class and respective places.

from android-week-view.

jhoobergs avatar jhoobergs commented on July 29, 2024

I think lines like https://github.com/Quivr/Android-Week-View/blob/develop/library/src/main/java/com/alamkanak/weekview/WeekView.java#L141 will break it then. The easiest thing might be to create a class 'WeekViewId' which has a single property id and people can then also override that class together with the WeekView class.

from android-week-view.

ShivamDev31 avatar ShivamDev31 commented on July 29, 2024

Ofcourse we have to change it at all the places. In the attributes too. I'm using String instead of long by replacing it all the required places.

from android-week-view.

jhoobergs avatar jhoobergs commented on July 29, 2024

Yes, but you use your own fork probably ? I would update it so people don't need to fork the repo but can just adapt it themselves by override some classes.

from android-week-view.

udaysrinath avatar udaysrinath commented on July 29, 2024

Just following up on this @jhoobergs , you mentioned you are going to update it, do you have a proposed solution merged already?

from android-week-view.

udaysrinath avatar udaysrinath commented on July 29, 2024

Any update on this front @jhoobergs ? Did you get a chance to get the changes for this?

from android-week-view.

jhoobergs avatar jhoobergs commented on July 29, 2024

@udaysrinath I probably won't have time to do it myself in the next month. If you want to fix it yourself, just create a PR and I will find the time to review it.

from android-week-view.

udaysrinath avatar udaysrinath commented on July 29, 2024

@jhoobergs Opened a PR for this, can you please review?

from android-week-view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.