Events ending at midnight not showing up

[quivr]

Events ending at midnight not showing up

[jhoobergs]

@nbeuret I'm sorry for the late reply, seems I forgot to. Can you add an event to the example class from 17 tot 00 ? And check if that event is shown ? If you push it to a fork, I can also test it and debug.

[Menthuss]

Can confirm this bug. Any event that ends at 00:00 is not shown.

EDIT: I've figured out what's causing this issue:
Inside the expandEventsToMaxWidth(List<EventRect> collisionGroup) method in the WeekView class, at line 1414 this statement is the root cause:
eventRect.bottom = getPassedMinutesInDay(eventRect.event.getEndTime());

For events where the endTime is midnight of the next day, the getPassedMinutesInDay() method will return 0.
Later on, when the library tries to render the rectangle for the event in the drawEvents(Calendar date, float startFromPixel, Canvas canvas) method, the following statement, bottom = mHourHeight * bottom / 60 + mCurrentOrigin.y + mHeaderHeight + mHeaderRowPadding * 2 + mHeaderMarginBottom + mTimeTextHeight/2 - mEventMarginVertical - marginTop; at line 1039 will produce a negative float because bottom is 0.

Finally, the If statement at line 1050 if (left < right && left < getWidth() && top < getHeight() && right > mHeaderColumnWidth && bottom > mHeaderHeight + mHeaderRowPadding * 2 + mTimeTextHeight / 2 + mHeaderMarginBottom) that determines whether or not the EventRect has valid coordinates will fail and result in the event's rectangle getting set to null.

[Menthuss]

@jhoobergs Any chance you could take a look at my pull-request that fixes this issue any time soon?