Click on empty item

[quivr]

Click on empty item

[jhoobergs]

You can use the property newEventTimeResolutionInMinutes
You should set it to 60 if you want that 7.00 to 8.00 is highlighted and to 1 if you want 7.23 to 8.23 to be highlighted. The default is 15, so it would highlight from 7.15 to 8.15 (or maybe 7.30 to 8.30 not 100% sure)

Thank you for the quick response. But it works incorrectly. When I click on 7:29 it works correctly, but when on 7:31 highlighted next our, that is from 8:00 to 9:00

[jhoobergs]

This is with a resolution of 60 ?

Yes

[jhoobergs]

I see. The reason is that it always takes the closest time (8 in case of 7.31) as the start time. For events of 1 hour, this might seem a bit strange, but for events of 2 hours, that's more logical.

And can I fix it for events of 1 hour like Google Calendar?

[jhoobergs]

The code is at https://github.com/Quivr/Android-Week-View/blob/develop/library/src/main/java/com/alamkanak/weekview/WeekView.java#L335

It would actually be best to change this code so it returns the interval (with length == resolutionInMinutes) in which the clicked time lies.

This would mean:

• if resolution = 60 and time = 7.41 -> 7.00 to 8.00 (now 8 to 9)

• if resolution = 120 and time = 7.41 -> 6.00 to 8.00 (now 8 to 10)

• if resolution = 15 and time = 7.41 -> 7.30 to 7.45 (now 7.45 to 8.00)

  This would mean something like:
  startMinute = (selectedTime.get(Calendar.MINUTE) / mNewEventTimeResolutionInMinutes) * mNewEventTimeResolutionInMinutes (the first is an integer division) and endMinute = startMinute + mNewEventTimeResolutionInMinutes

Yes, that would be correct

[jhoobergs]

@devoma Do you have the time to fix this and create a PR ?

Maybe create an option to choose between the 2 types, because I think you sometimes want it to go to the closest start instead of the interval in which it lays. The field can be named mNewEventSelectionType and the type would be an Enum EventSelectionType with 2 values: InInterval and ClosestStartTime

It would also be nice if a listener could be used to create your own types maybe ? But that's not the key point.

I'm ready to take it. But while I do not have time, and I can't before February. I want to contribute to this great library