Giter Site home page Giter Site logo

Comments (12)

waseem01 avatar waseem01 commented on August 22, 2024

I will fix this inshaAllah, @mohamede1945 please add me to the project so I can assign it to myself

from quran-ios.

ahmedre avatar ahmedre commented on August 22, 2024

@waseem01 @mohamede1945 i've added an "in progress" label that we can label things people are working on with instead of adding to the project.

from quran-ios.

waseem01 avatar waseem01 commented on August 22, 2024

@ahmedre Thanks, I dont have 'write permissions' to the repo to move it :)

from quran-ios.

ahmedre avatar ahmedre commented on August 22, 2024

we're not adding people with write permissions to the project right now for a few reasons:

  1. as a "github organization," we pay depending on the members in the organization
  2. we want to restrict checkin permissions to the code so only approved pull requests get merged

i also looked to see if there's a way to just give permissions to add labels and what not, but i didn't see that, though i could have missed it.

from quran-ios.

ahmedre avatar ahmedre commented on August 22, 2024

as an aside, most open source projects work this way - i.e. you don't get write permissions to most of the repositories to be able to contribute - the maintainers are responsible for looking at pull requests, reviewing them, and merging code accordingly.

from quran-ios.

ahmedre avatar ahmedre commented on August 22, 2024

oh - and i forgot, most importantly - jazakAllah khairan in advance!

from quran-ios.

waseem01 avatar waseem01 commented on August 22, 2024

Thanks, I will open a PR and I guess the admin can merge.

from quran-ios.

mohamede1945 avatar mohamede1945 commented on August 22, 2024

@waseem01 I don't know why I'm not able to reproduce the issue. Can you have tell me which reciter were you using?

from quran-ios.

mohamede1945 avatar mohamede1945 commented on August 22, 2024

@ahmedre Thanks a lot for creating the label. I was mainly depending on zenhub for such things, but I think I should use labels too since it will be easier for everyone.

from quran-ios.

mohamede1945 avatar mohamede1945 commented on August 22, 2024

Gif of the issue:
g7jxoq

from quran-ios.

mohamede1945 avatar mohamede1945 commented on August 22, 2024

I'll start working on this issue now.

from quran-ios.

mohamede1945 avatar mohamede1945 commented on August 22, 2024

Can't reproduce anymore.

from quran-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.