Giter Site home page Giter Site logo

FPL Abs bug about ecsharp HOT 3 OPEN

ZhangHuan0407 avatar ZhangHuan0407 commented on July 26, 2024
FPL Abs bug

from ecsharp.

Comments (3)

ZhangHuan0407 avatar ZhangHuan0407 commented on July 26, 2024

I think the result of FPL16.Abs cannot be negative.
Version: Nuget 30.1.1

// Decompile the code
public FPL16 Abs()
{
return Prescaled((N >= 0) ? N : (-N));
}

// Modified
public FPI16 Abs()
{
Int32 valueN = N;
if (valueN == MinValue.N)
valueN = MaxValue.N;
return Prescaled(valueN >= 0 ? valueN : -valueN);
}

// dotnet source code
https://referencesource.microsoft.com/#mscorlib/system/random.cs,61
They changed MinValue to MaxValue where they didn't expect an error.

System.Math.Abs throw exception, if value equal long.MinValue.

Console.WriteLine(Math.Abs(float.MinValue)); // 3.4028235E+38

Are fixed point and decimal more similar?

from ecsharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.