Comments (4)
See the NEWS file, you need to actively set the withr.hook_source
option when sourcing outside of the global env.
I would just use local()
in that example though.
from withr.
I would rather not clutter up package examples with extra nesting/option setting... let me take a look tomorrow at how else to support this use case. We're not failing on CRAN so presumably it's an issue with the CI script.
FWIW I would call out this use case (local_tempfile() inside package examples) in the NEWS, I read that bullet but didn't make the connection because the source() usage is several layers deep.
from withr.
CRAN is sourcing in the globalenv, which explains why source()
works out of the box.
By the way @gaborcsardi let me know that this only works because your example is conditional. If you remove the condition, the generated R code will no longer be fenced by source()
, and withr will stop working 100% as expected. The exit handlers will be run after all examples have completed rather than at the end of the particular example withr was used. So local()
is definitely still recommended in examples.
from withr.
Got it, thanks for the elaboration. In that case I will just stick with un-hooked file cleanup, using local()
in examples will be confusing for novice readers IMO.
I see two other CRAN packages that may be affected:
from withr.
Related Issues (20)
- `with_options` differs from `options()` HOT 2
- Should deferred_run() work within knitr? HOT 4
- Failing test in test suite HOT 6
- `get_par` ignores `no.readonly`
- Use standalone check functions
- `local_pdf()` and friends should default to using a local temporary file
- withr `3.0.0` breaking gh actions HOT 3
- Warnings when running tests using withr HOT 4
- `deferred_run` doesn't find attached handlers HOT 1
- "replace" is prefixing in `with_temp_libpaths` and friends
- Usage instructions for with_tempdir is unclear
- local_package() used in a function detaches package from global environment HOT 1
- with_package does not clean up Depends
- Update knitr defer code after evaluate 1.0.0
- CRAN notice: issues need fixing before 2024-07-31 HOT 9
- set locale warnings in documentation HOT 1
- Drop support for R 3.5 and earlier
- Switch from `on_load()` to our latest technique
- Breaking change in local_connection: passing list(conn) used to work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from withr.