[BUG] Weird decklist causing a crash in the app

[phated]

[BUG] Weird decklist causing a crash in the app

[r0adkll]

Thanks for the detailed report! I'll take a look into this and see what's going wrong

[mmxxiii]

Confirmed. It happens on my Samsung Galaxy S8 as well. Imports fine, but crashes when I try to open the decklist.

[mmxxiii]

Simplified import which crashes the app:

****** DeckBox Crash List ******

##Pokémon - 5

* 1 Oddish JU 58
* 1 Oddish HL 68
* 1 Oddish EX 122
* 1 Oddish UNB 5
* 1 Oddish UNB 6
* 1 Gloom UNB 7

##Trainer Cards - 0

##Energy - 0


Total Cards - 5

****** Deck List Generated by DeckBox ******

Anytime there are more that 5 different cards of the previous evolution of a pokemon, it crashes with the same error.

[phated]

The issue seems to be the use of parent.getChildAt with a RecyclerView, which returns null if the item is outside of a "row"

I found this on stack overflow:

When there is more than one page of data in your recycler view and you're using getChildAt() method, it will throw a null pointer exception. This is because when the position is greater than the number of visible items on the display, getChildAt() won't work as it can only get to the view that is displayed on the screen.

Therefore, use recyclerView.layoutManager?.findViewByPosition(position) to get the view at the given position.

[phated]

Fixed by #141