Decouple `stream` query parameter from Client module

[r3labs]

Decouple `stream` query parameter from Client module

[purehyperbole]

Sorry for the delayed response.

You're quite right. that works much better :)

I'lll update the PR with those changes and merge.

Thanks again for the feedback

[purehyperbole]

Thanks, happy you like the library!

This is actually something that has bugged me for a while. The stream functionality was included for internal usage at R3 Labs and maybe isn't all that useful to anyone else.

I'm happy to expose functionality to allow custom query parameters, however i'm reluctant to change the default behaviour as i'm not sure who is dependant on that.

Would something like the following work for your usecase?:

// define params as map 
params := map[string]string{
    "search": "example",
}

c := sse.NewClient("https://someurl")

// set query params, overwriting the default of stream = ?
c.SetQueryParams(params)

[purehyperbole]

I've implemented a few changes that keep the current interfaces intact (on the query-params branch), but allow you to specify what query params are set.

The only caveat is that custom params will need to use client.SubscribeRaw and client.SubscribeStreamRaw to avoid having the params overwritten with the stream param.

Please let me know if this addresses your use case

Cheers

[campbellwmorgan]

@purehyperbole That looks awesome! Nice work and thanks for getting on this so quickly. Much appreciated!

My only comment is that on thinking about it, perhaps you are over-complicating it because I think here the query variable will already contain all of the query options from the URL on the client struct, so in theory all you need is just an if clause so that an empty query parameter isn't given.

Before I knew you were working on this, I did campbellwmorgan@a5e14a8, but to make it readable you could use your client.SubscribeRaw which calls client.Subscribe with an empty stream variable?