Giter Site home page Giter Site logo

Comments (2)

rabanti-github avatar rabanti-github commented on May 16, 2024 1

Hi,
This feature is currently not supported. However, that feature would perfectly fit into the further development (I was already thinking about it and have added it now to the development backlog).

There are some considerations to make regarding comments. Comments can be inline-formatted. Inline-formatting is not yet implemented but on top of the backlog. In a first step, plain text comments could be implemented. Since I try to provide any function of PicoXLSX to NanoXLSX (the successor project that has reader support, has now the development lead and is also more active recently), a reader for comments should also provided as well. Comments should probably managed in a new class 'Comment' or 'Note' and stored in a Dictionary on the worksheet, where the key ist the cell address of the comment and the value the comment instance. The instance would probably hold meta information like visible state, size, comment creator, etc.

If you have already code - even if no reader or formatting is included - it would be great if you could share it. Any help is appreciated.

How I recently handle PRs:

  1. Clone NanoXLSX(*), create a feature branch and add your code
  2. Create a PR that is pointing to the dev-pr branch of NanoXLSX
  3. I will review it, and will do some comments if fundamental things should be fixed
  4. After fixing the mentioned things, I will merge the branch and will add further things
    • Comments where necessary and documentation
    • Minor changes for consistency reasons
    • Tests if none are defined
    • Updating of the change log and readme if necessary
  5. When everything is ready, I will merge dev-pr to dev and create a release with a NuGet package
  6. After releasing, dev will be merged to master
  7. All writer-features will be ported from NanoXLSX to PicoXLSX by myself ASAP and also released

(*)If you want to do a PR, but NanoXLSX is not the thing you are looking for, a PR to the dev-pr branch of PicoXLSX is also possible. In this case, the feature porting would be from PicoXLSX to NanoXLSX

Thank you in advance

from picoxlsx.

nvivo avatar nvivo commented on May 16, 2024

Thanks for the help. I'll try it here, if I'm able to do it I'll do the PR

from picoxlsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.