rabbitmq 3.8 new cluster_status cli output breaks cluster resource

[jtschelling]

rabbitmq 3.8 new cluster_status cli output breaks cluster resource

[michaelklishin]

This cookbook's master has long dropped RabbitMQ 3.6 support and bumped the major version. That series has been out of support for 19 months in general. I would not mind dropping support for it in v5.x with a clear warning in the change log.

[jtschelling]

are you thinking divergent code paths based on running rabbit version or a major bump of this cookbook dropping RabbitMQ version <3.7 support? I can put up a PR for this if you want, just wanna make sure i'm on the same page as you

[jtschelling]

this can be observed by running sudo rabbitmqctl cluster_status on a 3.7 rabbit node and then on a 3.8 node to see the output differences and why the string would not be parsed correctly

[lukebakken]

I suggest using the JSON formatter:

rabbitmqctl cluster_status --silent --formatter json

[michaelklishin]

@jtschelling we are quite aware of the changes. Are there examples of Chef resources that capture JSON output that you can recommend?

[jtschelling]

@lukebakken I know you know - hah - but just noting here that 3.7 and 3.8 both have the same running_nodes field that would be perfect for cross-compatibility here. Was that formatter flag introduced at some previous version of rabbit or there since the beginning? It seems like the best way to fix this, but if that json formatter flag was introduced at 3.6 or something there'd still be compatibility issues that would need to be denoted or code path changed in this cookbook

@michaelklishin since you're using the provider design pattern in this cookbook I'd probably just use the ruby core native json module

[lukebakken]

JSON formatting is supported since version 3.7.0:

(20.3)lbakken@MESSIAEN ~/issues/rmq-generic-unix/rabbitmq_server-3.7.0
$ ./sbin/rabbitmqctl cluster_status --formatter json
{"nodes":{"disc":["rabbit@MESSIAEN"]},"running_nodes":["rabbit@MESSIAEN"],"cluster_name":"rabbit@localhost","partitions":[],"alarms":{"rabbit@MESSIAEN":[]}}

RabbitMQ 3.6 isn't supported anymore and the RMQ team does everything we can to discourage its use.