rabobank-nederland/omnikassa-sdk-doc

This repository contains the developer documentation for the Rabo Omnikassa SDKs

omnikassa-sdk-doc's Issues

merchantOrderId field length limited to 24 characters

Looking at the schema for the order announce call, the description of the merchantOrderId mentioned some strange behavior for this property. It looks like the specification changes dynamically depending on another property called shopperBankstatementReference.
Searching on github, I found this 'java only' code:

         * @param merchantOrderId | Must not be `null`
         *                        | - if shopperBankstatementReference is supplied:
         *                        |   Allows all ascii characters up to a length of 255 characters, if the ID contains more than 255 characters, the extra characters are removed after the 255th character.
         *                        | - else:
         *                        |   Must adhere to the pattern: '[A-Za-z0-9]{1,24}', if the ID contains more than 24 characters, the extra characters are removed after the 24th character.
         * @return Builder
         */
        public Builder withMerchantOrderId(String merchantOrderId) {
            this.merchantOrderId = merchantOrderId;
            return this;
        }

Schema description of shopperBankstatementReference:
Generated by the webshop. The value of this field must be unique when offering Riverty/AfterPay as a payment brand to the customer. If the ID contains more than 24 characters, the extra characters are removed after the 24th character.

When shopperBankstatementReference has a value, the merchantOrderId property suddenly is allowed to contain 255 characters? That is strange behavior.

It's very common to use GUID's as a way to create unique ID's. A string representation of a GUID needs at least 32 characters (leaving out braces and hyphens). So, GUID's can't be used as a merchantOrderId.

The 'shopperBankstatementReference' change has been made recently. Apparently Java only, and not for .NET, PHP and sdk documentation. Is it a trial feature?

Question: is it possible to change the API to always have 255 characters for the merchantOrderId? Or at least 32?

Explain Billing Address setup for company invoices

The readme is targeting B2C, but from the text itself it remains unclear how the billing address should be structured for an order for a company.

The billing address is recommended for some payment brands, but allows not both specification of company name and first / last name.

Also, often street name, house number and addition are not available in split format. Some recommendations whether a merged variant is allowed would be welcome.