Do not use sync IO methods

[rafalwilinski]

Do not use sync IO methods

[RafalWilinski]

it's happening only once, when server starts and takes less than couple of
ms to handle. I don't think it's an issue.
On Mon, 22 Aug 2016 at 16:19, Petr Huřťák [email protected] wrote:

In

https://github.com/RafalWilinski/express-status-monitor/blob/master/index.js#L99-L100

  .replace(/{{script}}/g, fs.readFileSync(path.join(__dirname, '/app.js')))
  .replace(/{{style}}/g, fs.readFileSync(path.join(__dirname, '/style.css')));

You are using sync methods, this seems like a bad idea. As far as I know,
sync methods will block the whole thread, while doing the IO. If you use
async method, that thread will be free to handle other requests until
feadFile is finished.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADPAgPWn7ejVmJS0k2clKFsXgd-TKr_lks5qibANgaJpZM4Jp6zX
.