Giter Site home page Giter Site logo

Comments (10)

rahulrj avatar rahulrj commented on August 30, 2024

@GadgetCheck , Will look into it. As it was just a demo, i hardcoded the dp values into the app. So this problem might arise. Will fix this.

from yahoonewsonboarding.

GadgetCheck avatar GadgetCheck commented on August 30, 2024

Rahul, i was trying to fix it but no luck (wanted to apply this to my app today :D). would be great if you could fix it.

I am not able to draw it in the centre.

Waiting for your patch.

Its happening on the second and third layouts that is sunmoonview and thirdscreen view.

from yahoonewsonboarding.

rahulrj avatar rahulrj commented on August 30, 2024

Okay. I will fix this by today or most probably by tomorrow. For center horizontal, i guess i will have to pass x-co-ordinate as deviceWidth/2.

from yahoonewsonboarding.

GadgetCheck avatar GadgetCheck commented on August 30, 2024

Yeah, like i tried it on an oneplus 2 and all the 3 screens went out of proportion, even on a note 5 same thing happened. I am guessing you need to make it automatically scale up/down.

Like the yahoo app scaled like a charm.

from yahoonewsonboarding.

rahulrj avatar rahulrj commented on August 30, 2024

@GadgetCheck can you please send me a screenshot of the distorted screen on my mail [email protected] or you can attach here also?

from yahoonewsonboarding.

serkandyck avatar serkandyck commented on August 30, 2024

hey rahul here screen nexus 5 first steep fine
http://i57.tinypic.com/juzfpv.png step 2
http://i59.tinypic.com/s3opcw.png Step 3

from yahoonewsonboarding.

rahulrj avatar rahulrj commented on August 30, 2024

HI.
I improved the second and third screen to a good extent by dynamically sizing the contents. It should work for now.But its not a full proof solution. Give me time upto Monday. I will make all the three screens resizable across most of the devices.

from yahoonewsonboarding.

GadgetCheck avatar GadgetCheck commented on August 30, 2024

Done bro, awesome job. Waiting for the proper fix.

from yahoonewsonboarding.

rahulrj avatar rahulrj commented on August 30, 2024

@GadgetCheck @asdstyle33 I have made the fixes for dimensions and tested also in the emulators. You can use them.

from yahoonewsonboarding.

GadgetCheck avatar GadgetCheck commented on August 30, 2024

Perfect thanks @rahulrj

from yahoonewsonboarding.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.