Giter Site home page Giter Site logo

Comments (3)

metaskills avatar metaskills commented on May 23, 2024

Well I added the change because it did not break anything. A regression test would have been ideal as it would mean this does not get removed in later version. Can you come up with one?

from activerecord-sqlserver-adapter.

WCWedin avatar WCWedin commented on May 23, 2024

Unfortunately, I'm not that strong in either Ruby or Rails, and I don't have the time at the moment to dig through the test suit and figure out all of the appropriate idioms. I pretty much only discovered this bug because Redmine is affected by it; I'm more of a savvy consumer than a legit developer in that regard. That said, if I can dedicate myself to the task in the near future, I'll take a crack at it.

from activerecord-sqlserver-adapter.

metaskills avatar metaskills commented on May 23, 2024

Closing this ticket since this change is in.

from activerecord-sqlserver-adapter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.